The current limitations are the only the first 4k byte are used to find a package name, and that it fails if only one file has a different file name (for example in golang.org/x/net/ipv4 there is a file called gen.go that's not part of the package, and thus prevents go-mode-add-package-line from doing anything). These could easily be fixed, but I'm not sure what the correct behavior is from the Go-side of things.

I wonder if the correct thing to do would be to pick the package name that occurs most frequently?

Also, it looks like this patch doesn’t seem to handle package foo_test for _test.go files, inside package foo?

I wonder if the correct thing to do would be to pick the package name that occurs most frequently?

That could also be done, but I assume that there could be difficulties when there are an approximately equal number of packages in a directory. It would probably be best to provide a local-safe user option to decide how to do this.

Also, it looks like this patch doesn’t seem to handle package foo_test for _test.go files, inside package foo?

The last update should fix that.

I wonder if the correct thing to do would be to pick the package name that occurs most frequently?

That could also be done, but I assume that there could be difficulties when there are an approximately equal number of packages in a directory. It would probably be best to provide a local-safe user option to decide how to do this.

There are four cases that all seem to have a sensible default:

1. The buffer represents the first .go file in the directory.
   1. In this case, it seems sensible to guess that the package name is the directory name.
2. There is only one package name that shows up in the directory.
   1. Use that name. This is what your code does now.
3. There are multiple packages in the directory, but one of them is most frequent.
   1. Use the most frequent name.
4. There are two package names that have the most .go files in the directory.
   1. If one of the package names matches the directory name, that is probably the best default.
   2. Otherwise, pick one of the most frequent names at random.

FYI gopls provides completion for the package statement now in empty files.