Suggest strings.ContainsFunc instead of strings.IndexFunc with Go 1.21+#1435
Open
scop wants to merge 1 commit intodominikh:masterfrom
Open
Suggest strings.ContainsFunc instead of strings.IndexFunc with Go 1.21+#1435scop wants to merge 1 commit intodominikh:masterfrom
scop wants to merge 1 commit intodominikh:masterfrom
Conversation
7fb55ea to
0cd4d75
Compare
0cd4d75 to
1c3615e
Compare
Author
|
Reworked against current master. |
Author
|
@dominikh JFYI in case it went unnoticed, I rebased this against current master a couple of days ago, should be ready to go. |
|
The PR is 3 years old. The need is real. But isn't isn't this addressed by Go official modernizer ? Now shipped with go fix ? |
Owner
I saw, thanks. I'll try to look at this soon, as I work through my backlog. Though if this is in |
Author
|
Modernize/go fix only do slices.Contains(Func), not the corresponding strings/bytes ones staticcheck does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.