Update to latest Azure.Core package with Azure.Identity types#4200
Update to latest Azure.Core package with Azure.Identity types#4200ErikEJ wants to merge 6 commits intodotnet:mainfrom
Conversation
(which now contains the Azure.Identity types) https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/MigrationGuide.md
There was a problem hiding this comment.
Pull request overview
This PR updates centrally-managed package versions (Azure.Core, Microsoft.Identity.Client) and attempts to remove the Azure.Identity dependency from the Extensions.Azure project configuration.
Changes:
- Bump
Azure.Coreto1.53.0andMicrosoft.Identity.Clientto4.83.1inDirectory.Packages.props. - Remove the
Azure.Identitypackage reference fromsrc/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj. - Remove the centrally managed
Azure.Identitypackage version fromDirectory.Packages.props.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj |
Removes Azure.Identity PackageReference (currently breaks compilation due to existing Azure.Identity usage). |
Directory.Packages.props |
Updates shared dependency versions and removes central Azure.Identity version (currently breaks restore/build for projects that still reference Azure.Identity). |
Comments suppressed due to low confidence (1)
src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj:135
- Removing the Azure.Identity PackageReference will break compilation: this project still uses Azure.Identity types (e.g.,
using Azure.Identity;andDefaultAzureCredential,ManagedIdentityCredential, etc. inActiveDirectoryAuthenticationProvider.cs). Re-add theAzure.Identityreference (or remove/replace all Azure.Identity usages if the intent is to drop the dependency).
<ItemGroup>
<PackageReference Include="Azure.Core" />
<PackageReference Include="Microsoft.Extensions.Caching.Memory" />
<!-- Explicitly depend on the same version of Microsoft.Identity.Client as SqlClient. -->
<PackageReference Include="Microsoft.Identity.Client" />
</ItemGroup>
|
@ErikEJ - Sure, you can update the sample app. I think it should point to the latest published packages (7.0.0, 1.0.0). It looks like Microsoft.Identity.Client has version 4.83.3 now. I've added it and 4.83.1 to our NuGet feed. I also added Azure.Core 1.53.0. I'll add any other new packages as they are identified (by build failures). |
|
@paulmedynski I will bump Microsoft.Identity.Client to version 4.83.3 and have a look at the sample app |
Update sample app and readme
|
@paulmedynski All updated now, not 100% sure about the readme changes for the sample app |
|
Look like Microsoft.Identity.Client.Extensions.Msal 4.38.3 is missing from your DevOps feed |
|
@paulmedynski How nice that PR builds run these days - thanks everyone for that! |
Unfortunately they still need an Do not despair though, we're going to see if we can get the PR pipelines to not require any secrets, which would allow them to run automatically - stay tuned! |
|
@paulmedynski Working on fixing the samples build |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj:135
- This project still has source files that
using Azure.Identity;and use credential implementations like DefaultAzureCredential (see ActiveDirectoryAuthenticationProvider.cs). With Azure.Identity removed from the package references, the build will now depend on those types being present in Azure.Core, which may not be true. If the types are still provided by Azure.Identity, re-add the package reference (or update the code to the new package/type locations).
<ItemGroup>
<PackageReference Include="Azure.Core" />
<PackageReference Include="Microsoft.Extensions.Caching.Memory" />
<!-- Explicitly depend on the same version of Microsoft.Identity.Client as SqlClient. -->
<PackageReference Include="Microsoft.Identity.Client" />
</ItemGroup>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Looks this will be a build time breaking change for users that have an explicit reference to an older Azure.Identity version- but with an easy fix of course.. |
Update to latest Azure.Core package with Azure.Identity types (which now contains the Azure.Identity types)
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/MigrationGuide.md
This pull request updates shared dependency versions and removes an unused Azure dependency from the project configuration files. The main focus is on keeping dependencies up to date and cleaning up unnecessary references.
Dependency updates:
Azure.Coreto version1.53.0andMicrosoft.Identity.Clientto version4.83.3inDirectory.Packages.propsto ensure the latest features and security patches are used.Dependency cleanup:
Azure.Identitypackage version specification fromDirectory.Packages.propssince it is no longer needed.Azure.Identitypackage reference fromsrc/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csprojto clean up unused dependencies.Question: Should I update the app and readme in doc/apps/AzureAuthentication - it still refers to preview.4 etc?