fix(dotnet-test): fix agent frontmatter correctness issues#559
Draft
Evangelink wants to merge 2 commits intomainfrom
Draft
fix(dotnet-test): fix agent frontmatter correctness issues#559Evangelink wants to merge 2 commits intomainfrom
Evangelink wants to merge 2 commits intomainfrom
Conversation
- Fix typo: user-invokable -> user-invocable in test-migration agent - Add missing tools field to 7 sub-agents (builder, tester, linter, fixer, planner, researcher, implementer) following least-privilege - Add missing user-invocable: false to planner, researcher, tester (internal pipeline agents that shouldn't appear in agent picker) - Add agents restriction to generator and implementer to scope which sub-agents they can invoke
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dotnet-test plugin’s agent frontmatter to improve correctness and tighten agent capabilities (least privilege) for the test-generation pipeline.
Changes:
- Fixes a frontmatter key typo on
test-migration(user-invokable→user-invocable). - Adds explicit
toolsallowlists to multiple pipeline sub-agents and addsagentsallowlists to orchestrators. - Marks certain pipeline sub-agents as non-user-invocable.
Show a summary per file
| File | Description |
|---|---|
| plugins/dotnet-test/agents/test-migration.agent.md | Updates the user-invocable frontmatter key for the agent picker behavior. |
| plugins/dotnet-test/agents/code-testing-tester.agent.md | Adds a restricted tools list and sets user-invocable: false. |
| plugins/dotnet-test/agents/code-testing-researcher.agent.md | Adds restricted tools and non-user-invocable flag (currently duplicated). |
| plugins/dotnet-test/agents/code-testing-planner.agent.md | Adds a restricted tools list. |
| plugins/dotnet-test/agents/code-testing-linter.agent.md | Adds a restricted tools list. |
| plugins/dotnet-test/agents/code-testing-implementer.agent.md | Adds restricted tools and an agents allowlist for delegation. |
| plugins/dotnet-test/agents/code-testing-generator.agent.md | Adds an agents allowlist to scope delegation to the intended pipeline agents. |
| plugins/dotnet-test/agents/code-testing-fixer.agent.md | Adds a restricted tools list. |
| plugins/dotnet-test/agents/code-testing-builder.agent.md | Adds a restricted tools list. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/9 changed files
- Comments generated: 2
Member
Author
|
/evaluate |
Contributor
|
⏭️ No skills to evaluate — no changed skills with tests were found in this PR. View workflow run |
- Remove duplicate user-invocable: false in code-testing-researcher - Revert test-migration back to user-invokable (repo-consistent spelling) Both spellings appear to be accepted by VS Code; keeping user-invokable for user-facing agents to stay consistent with other plugins in the repo.
Member
Author
|
Moving back to draft so we can discuss some potential impact with @JanKrivanek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several frontmatter correctness issues in dotnet-test agents, aligned with VS Code custom agent best practices.
Changes
Fix typo:
user-invokable→user-invocableuser-invocable(with a c). The misspelled property was silently ignored.Add missing
toolsfield to 7 sub-agentsPer the principle of least privilege, each sub-agent now declares only the tools it needs:
code-testing-builderread,search,terminalcode-testing-testerread,search,terminalcode-testing-linterread,search,terminalcode-testing-fixerread,search,editcode-testing-plannerread,search,editcode-testing-researcherread,search,edit,taskcode-testing-implementerread,search,edit,taskPreviously these agents had no
toolsfield and inherited defaults, giving them more capability than needed.Add missing
user-invocable: falseto 3 sub-agents.testagent/state created by the orchestrator. They should not appear in the agent picker dropdown.Add
agentsrestriction to orchestratorsThis prevents accidental delegation to unrelated agents.