Conversation
added 3 commits
September 22, 2021 09:30
Not perfect test coverage but enough to get *some* confidence it's mostly right. More to come. Signed-off-by: Amy Tobey <[email protected]>
edw-eqix
suggested changes
Sep 22, 2021
Contributor
edw-eqix
left a comment
There was a problem hiding this comment.
Don't think my comment about validation needs to be in this PR but it would be good to clarify the wording about keys in the simple_carrier_test
that's what I get for copying from otel-cli Signed-off-by: Amy Tobey <[email protected]>
edw-eqix
approved these changes
Sep 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds:
All of which I've wanted a few times recently and mainly need ContextWithCmdlineOrEnvTraceparent for some work happening now.