Skip to content

feat: Metal CLI support create shared interconnection with vlans and vrfs#397

Merged
ctreatma merged 13 commits intoequinix:mainfrom
aayushrangwala:interconn-create-enhancement
Jan 23, 2024
Merged

feat: Metal CLI support create shared interconnection with vlans and vrfs#397
ctreatma merged 13 commits intoequinix:mainfrom
aayushrangwala:interconn-create-enhancement

Conversation

@aayushrangwala
Copy link
Copy Markdown
Contributor

@aayushrangwala aayushrangwala commented Nov 28, 2023 •
edited by displague
Loading

Part of #307

@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 136f43f to e2f6f0b Compare December 17, 2023 02:58
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from e2f6f0b to ad1ff3a Compare December 17, 2023 03:05
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 948a0d6 to 75a1af5 Compare December 18, 2023 17:38
@displague
Copy link
Copy Markdown
Member

displague commented Dec 18, 2023

Since this will need to be rebased. Perhaps after rebase we can add the 3 or so lines to pick up #388 (keep in mind, this changed with #331).

@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 75a1af5 to ce56c12 Compare December 19, 2023 10:49
@aayushrangwala aayushrangwala changed the title fix: Metal CLI support create shared interconnection with vlans and vrfs feat: Metal CLI support create shared interconnection with vlans and vrfs Dec 19, 2023
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from ce56c12 to 8453157 Compare December 19, 2023 15:46
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from f532cdf to 8a9be52 Compare December 19, 2023 16:12
@aayushrangwala aayushrangwala marked this pull request as ready for review December 19, 2023 16:15
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 62d3a0c to 7df355a Compare December 20, 2023 17:32
@aayushrangwala
Copy link
Copy Markdown
Contributor Author

aayushrangwala commented Dec 20, 2023

Since this will need to be rebased. Perhaps after rebase we can add the 3 or so lines to pick up #388 (keep in mind, this changed with #331).

@displague Yes added the delete force changes in this PR

@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 7df355a to 9ab3560 Compare December 21, 2023 14:17
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 9ab3560 to 55e1d38 Compare December 21, 2023 14:36
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 55e1d38 to 5878365 Compare December 21, 2023 14:46
@aayushrangwala aayushrangwala requested a deployment to external January 18, 2024 19:31 — with GitHub Actions Abandoned
@aayushrangwala aayushrangwala requested a deployment to external January 18, 2024 21:44 — with GitHub Actions Abandoned
ctreatma
ctreatma reviewed Jan 18, 2024
View reviewed changes
Comment thread test/e2e/interconnections/create_test.go
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from dd01fe5 to 04b52c1 Compare January 19, 2024 18:14
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 89c4914 to 37edf4c Compare January 19, 2024 18:34
@aayushrangwala aayushrangwala requested a deployment to external January 19, 2024 19:56 — with GitHub Actions Abandoned
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from 37edf4c to d968556 Compare January 19, 2024 20:22
@aayushrangwala
feat: Add support for metal cli shared connections
16cba0b 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
refactor arg validation
33e8902 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
update random function generator
772efaf 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
fix: add default speed
7efe6c2 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
enhance: use force and confirmation while delete interconnections
82f0416
@aayushrangwala
fix: create interconnection cli flag descriptions
ad82f2a 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
docs update
062e38d 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
rollback adding '-' in test resources name as delimiter
c02e0cc
@aayushrangwala
update subcommand based on new api schema change
ad715c8 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
Add tests for create shared interconnections
22b94ef 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
Fetch current user and get default org to fetch conns for org
c81cfdf 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
Use patch fix in equinix-sdk-go
289c5c6 
fix: virtual circuit clan set speed int64
@aayushrangwala
Add wait for connection to be deleted
c1f6eb4 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala aayushrangwala force-pushed the interconn-create-enhancement branch from d968556 to c1f6eb4 Compare January 23, 2024 15:54
@aayushrangwala
Copy link
Copy Markdown
Contributor Author

aayushrangwala commented Jan 23, 2024 •
edited
Loading 

coverage: 9.8% of statements in ./...
ok  	github.com/equinix/metal-cli/test/e2e/interconnections	4.865s	coverage: 9.8% of statements in ./...

Tests are passing for the changes in this PR, hence we can merge it

ctreatma
ctreatma approved these changes Jan 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only test failure I see in CI is a platform issue affecting a pre-existing device test that is not modified in this PR.

@ctreatma ctreatma merged commit 2bb181a into equinix:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@displague displague displague left review comments

+2 more reviewers

@codinja1188 codinja1188 codinja1188 left review comments

@ctreatma ctreatma ctreatma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aayushrangwala @displague @ctreatma @codinja1188