fix: removing the obsolete PromptUI library from the project.#407
Merged
displague merged 1 commit intoequinix:mainfrom Dec 14, 2023
Merged
fix: removing the obsolete PromptUI library from the project.#407displague merged 1 commit intoequinix:mainfrom
displague merged 1 commit intoequinix:mainfrom
Conversation
displague
approved these changes
Dec 13, 2023
Member
displague
left a comment
There was a problem hiding this comment.
There's an opportunity to park the common code in a package, but I'm not concerned for this PR.
Member
Not related to this PR, but worth looking into. (@aayushrangwala is this something you're running into in #343?) |
This was referenced Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What fixes the PR?
#331