Skip to content

feat: Enabled VRF IP reservations#418

Merged
ctreatma merged 1 commit intoequinix:mainfrom
codinja1188:ipReservations
Jan 24, 2024
Merged

feat: Enabled VRF IP reservations#418
ctreatma merged 1 commit intoequinix:mainfrom
codinja1188:ipReservations

Conversation

@codinja1188
Copy link
Copy Markdown
Contributor

@codinja1188 codinja1188 commented Dec 19, 2023

No description provided.

displague
displague reviewed Dec 21, 2023
View reviewed changes
Comment thread internal/ips/request.go Outdated
Comment thread internal/ips/request.go Outdated
Comment thread internal/ips/request.go
Comment thread internal/ips/request.go Outdated
Comment thread internal/ips/request.go Outdated
Comment thread internal/vrf/ips.go Outdated
Comment thread internal/vrf/ips.go Outdated
Comment thread internal/vrf/ips.go Outdated
Comment thread internal/vrf/ips.go Outdated
@codinja1188 codinja1188 marked this pull request as ready for review December 22, 2023 14:09
ctreatma
ctreatma reviewed Jan 5, 2024
View reviewed changes
Comment thread internal/ips/request.go Outdated
Comment thread internal/vrf/ips.go Outdated
Comment thread internal/ips/request.go
ctreatma
ctreatma suggested changes Jan 19, 2024
View reviewed changes
Comment thread internal/vrf/ips.go Outdated
Comment thread internal/vrf/ips.go Outdated
Comment thread internal/vrf/ips.go Outdated
ctreatma
ctreatma reviewed Jan 19, 2024
View reviewed changes
Comment thread internal/vrf/ips.go Outdated
ctreatma
ctreatma suggested changes Jan 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was about to approve this because the only test failure in CI was a device test unrelated to this PR, but then I noticed there aren't any tests in this PR. Can you add some?

@ctreatma ctreatma merged commit 9fd3c2a into equinix:main Jan 24, 2024
@codinja1188
Copy link
Copy Markdown
Contributor Author

codinja1188 commented Jan 25, 2024 

Vasubabus-MacBook-Pro:bin vasubabu$ ./metal virtual-network create -m da --vxlan 3171
+--------------------------------------+-------------+-------+-------+-------------------------------+
|                  ID                  | DESCRIPTION | VXLAN | METRO |            CREATED            |
+--------------------------------------+-------------+-------+-------+-------------------------------+
| 106774e6-ac0f-49f6-8ba4-d2cc49d0e2b1 |             | 3171  | da    | 2024-01-22 20:52:49 +0000 UTC |
+--------------------------------------+-------------+-------+-------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal vrf create -p b4673e33-0f48-4948-961a-c31d6edf64f8 -d "cli-vrf-test5" -m da -n "cli-vrf-test5" -a 3171 -r "100.77.1.0/24"
+---------------+---------------+-------------+---------------+-------------------------------+---------+
|      ID       |     NAME      | DESCRIPTION |   LOCALASN    |           IPRANGES            | CREATED |
+---------------+---------------+-------------+---------------+-------------------------------+---------+
| cli-vrf-test5 | cli-vrf-test5 | 3171        | 100.77.1.0/24 | 2024-01-22 20:53:24 +0000 UTC |
+---------------+---------------+-------------+---------------+-------------------------------+---------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal vrf get
+--------------------------------------+------------------------+--------------------+----------------+----------+-------------------------------+
|                  ID                  |          NAME          |    DESCRIPTION     |    IPRANGES    | LOCALASN |            CREATED            |
+--------------------------------------+------------------------+--------------------+----------------+----------+-------------------------------+
| 4134ec51-6c34-4466-aa94-4fd757a8e962 | testvrf                | test-vrf           | 10.70.8.248/29 | 1245     | 2024-01-01 13:52:13 +0000 UTC |
| df18fbd8-2919-4104-a042-5d42a05b8eed | cli-vrf-ipreservations | vrf-ipreservations | 172.89.1.0/24  | 2021     | 2024-01-04 13:10:07 +0000 UTC |
| cbf2b07d-3ae2-406c-ae0c-cf49426d2780 | cli-vrf-test4          | cli-vrf-test4      | 100.75.1.0/24  | 1188     | 2024-01-05 13:45:25 +0000 UTC |
| 5981342d-ec6a-4370-bcf9-72f17d685f3d | cli-vrf-test5          | cli-vrf-test5      | 100.77.1.0/24  | 3171     | 2024-01-22 20:53:24 +0000 UTC |
+--------------------------------------+------------------------+--------------------+----------------+----------+-------------------------------+
Vasubabus-MacBook-Pro:bin vasubabu$ ./metal ip request -v 5981342d-ec6a-4370-bcf9-72f17d685f3d -t vrf --cidr 24 -n 100.77.1.0 --tags foobar --tags barfoo --customdata '{"my":"goodness"}' --details "i don't think VRF users need this or will see it after submitting the request"
+--------------------------------------+------+------------+--------+-------------------------------+
|                  ID                  | TYPE |  ADDRESS   | PUBLIC |            CREATED            |
+--------------------------------------+------+------------+--------+-------------------------------+
| 1d3f83fc-4b76-4370-983e-ad5b144544e3 | vrf  | 100.77.1.2 | false  | 2024-01-22 20:54:50 +0000 UTC |
+--------------------------------------+------+------------+--------+-------------------------------+

Vasubabus-MacBook-Pro:bin vasubabu$ ./metal ip remove -i 1d3f83fc-4b76-4370-983e-ad5b144544e3
IP reservation removed successfully.

@ctreatma ctreatma mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@displague displague displague left review comments

+1 more reviewer

@ctreatma ctreatma ctreatma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codinja1188 @displague @ctreatma @cprivitere