fix: handle optional flags correctly in VRF route update#441
Merged
cprivitere merged 4 commits intomainfrom Jan 31, 2024
Merged
fix: handle optional flags correctly in VRF route update#441cprivitere merged 4 commits intomainfrom
cprivitere merged 4 commits intomainfrom
Conversation
722eeaf to
d154c23
Compare
d154c23 to
9adc357
Compare
9adc357 to
b0f8be4
Compare
Contributor
|
Looks like the vrf-route-update-test is panicking after 30 seconds. |
Member
|
There have been conversations about adding a |
Contributor
Author
I see a panic happening in a different test due to the test timeout being reached (~1000 seconds) and the VRF route update test failing because the route isn't ready in time. I triggered a re-run of the tests to see if the route update times out again. We may need to extend the test timeout (terraform uses |
ctreatma
commented
Jan 30, 2024
displague
reviewed
Jan 30, 2024
b0f8be4 to
be77740
Compare
be77740 to
a065b4e
Compare
a065b4e to
49b4826
Compare
cprivitere
approved these changes
Jan 31, 2024
Contributor
cprivitere
left a comment
There was a problem hiding this comment.
Tests are flakey but passing in general. The ones added in this PR pass and that's what matters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test for the VRF route update subcommand was explicitly skipped. I added a helper function to wait for the VRF route to be ready before testing the update subcommand, but when the test was enabled it failed because the subcommand was not capable of updating tags without updating all other VRF route properties.
In addition to enabling the test for the VRF route update subcommand, this updates the subcommand itself so that it only updates a VRF route property if the user set the corresponding CLI flag.
Part of #414