Hi @yvikrant, It's difficult to review these changes when they don't abide by the published spec: https://developer.equinix.com/catalog/network-edgev1#operation/createDeviceACLTemplateUsingPost (subnet vs subnets, for example).

It would help if there was a changelog available to compare the spec differences against the changes here.
It would help if the deprecation plan was available for the fields being removed in this PR. If those fields are persisting in the API, it would be best not to remove those features from the client.

Because this client is a v1 client, these breaking changes will need to be considered with v2 semantics:
https://go.dev/blog/module-compatibility
https://codeengineered.com/blog/2019/go-mod-major-versions/

Hi @displague

Here's the old contract for creating ACL Template. I kept all the fields that are currently supported by API. Also, I have added comments against the properties which are deprecated.

{
    "name": "fqdn check",
    "description": "",
    "metroCode": "DC", // Deprecated as 
    "inboundRules": [
        {
            "srcType": "DOMAIN", // deprecated as FQDNs are not supported
            "protocol": "IP",
            "srcPort": "any",
            "dstPort": "any",
            "fqdn": "equinix.com", // Support Removed
            "subnets": [ // Deprecated and replaced with subnet
                "74.6.143.25/32",
            ],
            "seqNo": 1
        }
    ]
}

@displague . Added removed fields and marked them as deprecated. We'll plan to remove deprecated fields in the next major version.