Skip to content

sshInterfaceId for primary and secondary device in self configured devices#3

Merged
displague merged 3 commits intoequinix:masterfrom
rling-equinix:rui_develop
Nov 10, 2021
Merged

sshInterfaceId for primary and secondary device in self configured devices#3
displague merged 3 commits intoequinix:masterfrom
rling-equinix:rui_develop

Conversation

@rling-equinix
Copy link
Copy Markdown
Contributor

@rling-equinix rling-equinix commented Nov 8, 2021

Add sshInterfaceId for both primary and secondary device in self configured scenario when creating devices

Needed for equinix/terraform-provider-equinix#58

@displague displague changed the title Add sshInterfaceId for both primary and secondary device in self conf… sshInterfaceId for primary and secondary device in self configured devices Nov 9, 2021
Comment thread internal/api/device.go
InterfaceCount *int `json:"interfaceCount,omitempty"`
Core *DeviceCoreInformation `json:"core,omitempty"`
DeviceManagementType *string `json:"deviceManagementType,omitempty"`
SshInterfaceId *string `json:"sshInterfaceId,omitempty"`
Copy link
Copy Markdown
Member

@displague displague Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marques, this field is a string in API. For some reasons, it is an integer in the documentation. We are going to make the changes in swagger. In the payload of the documentation(the first link in your response), it's actually a string instead of integer. We will ask team to update it to be string.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spec, this is currently a value such as: 4. Why should it be a string? It seems an int would be the appropriate type unless other formats can be returned or set.

      sshInterfaceId:
        type: integer
        example: 4
        description: You may specify any available interface on the device as the sshInterfaceId. This field is only applicable to self-configured devices.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating the specs to change it to string. There is a possibility of sub-interfaces. In that case, we might use '-' or '.' to represent interface id

…ption when providing sshInterfaceId for equinix managed device
@displague displague merged commit d988fb5 into equinix:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants