equinix/resource_network_device_link.go:162

• metro_link is a TypeSet but the schema does not specify a Set hash function, while the read/flatten path tries to match existing items via networkDeviceLinkMetroLinkHash(...). Without setting Set: networkDeviceLinkMetroLinkHash, the hashes used by Terraform for the set won't match the custom hash used in flattenNetworkDeviceLinkMetroLinks, so account_number likely won't be carried forward and diffs will persist.

		networkDeviceLinkSchemaNames["MetroLinks"]: {
			Type:     schema.TypeSet,
			Optional: true,
			Elem: &schema.Resource{
				Schema: createNetworkDeviceLinkMetroResourceSchema(),
			},
			Description: networkDeviceLinkDescriptions["MetroLinks"],
		},

equinix/resource_network_device_link.go:527

• networkDeviceLinkMetroLinkKey uses networkDeviceLinkConnectionSchemaNames[...] when v is a map[string]interface{}. That map does not contain a "MetroCode" key (it uses src/dst metro codes), so the computed key/hash will be wrong and break matching of existing metro_link items. Use networkDeviceLinkMetroSchemaNames["MetroCode"|"Throughput"|"ThroughputUnit"] for the map case.

func networkDeviceLinkMetroLinkKey(v interface{}) string {
	if v, ok := v.(ne.DeviceLinkGroupMetroLink); ok {
		return fmt.Sprintf("%s-%s-%s",
			ne.StringValue(v.MetroCode),
			ne.StringValue(v.Throughput),
			ne.StringValue(v.ThroughputUnit))
	}
	if v, ok := v.(map[string]interface{}); ok {
		return fmt.Sprintf("%s-%s-%s",
			v[networkDeviceLinkConnectionSchemaNames["MetroCode"]],
			v[networkDeviceLinkConnectionSchemaNames["Throughput"]],
			v[networkDeviceLinkConnectionSchemaNames["ThroughputUnit"]])
	}

equinix/resource_network_acl_template.go:140

• inbound_rule.subnet is marked Optional: true in the schema, but the docs/templates in this PR describe it as required (and with subnets removed there's no longer an alternate source definition). Consider making subnet required to match the documented contract and avoid sending incomplete rules to the API.

		networkACLTemplateInboundRuleSchemaNames["Subnet"]: {
			Type:         schema.TypeString,
			Optional:     true,
			Description:  networkACLTemplateInboundRuleDescriptions["Subnet"],
			ValidateFunc: validation.IsCIDR,
		},