Skip to content

[ENH] - Add triangle periodic fit mode#376

Merged
TomDonoghue merged 8 commits intomainfrom
triangle
Apr 14, 2026
Merged

[ENH] - Add triangle periodic fit mode#376
TomDonoghue merged 8 commits intomainfrom
triangle

Conversation

@TomDonoghue
Copy link
Copy Markdown
Member

@TomDonoghue TomDonoghue commented Nov 18, 2025

This adds a new "triangle" periodic fit mode.

Implementation notes:

  • The currently defined 'triangle' is a symmetric triangle or sawtooth shape
  • It's defined to match the parameters of the gaussian (CF, PW, BW)

Usage notes:

  • However, there appear to be some quirks with using this in the existing fitting mode (e.g. bandwidth guesses don't seem great) such that it doesn't seem to end up on ideal solutions
  • Currently, this mode should be considered experimental

@fooof-tools fooof-tools deleted a comment from codecov Bot Nov 23, 2025
@fooof-tools fooof-tools deleted a comment from codecov Bot Dec 3, 2025
@fooof-tools fooof-tools deleted a comment from codecov Bot Apr 14, 2026
@TomDonoghue TomDonoghue merged commit 89b6d18 into main Apr 14, 2026
10 checks passed
@TomDonoghue TomDonoghue deleted the triangle branch April 14, 2026 17:26
@fooof-tools fooof-tools deleted a comment from codecov Bot Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant