returning original object of outputfiles#2411
returning original object of outputfiles#2411sidharth-sinhasane wants to merge 2 commits intoganga-devs:developfrom
Conversation
egede
left a comment
There was a problem hiding this comment.
I am afraid that this will not work. In outputfiles we can have wildcards. So consider the following
j = Job()
j.application.exe='touch'
j.application.args=['abcd.txt']
j.outputfiles=['*.txt']
If I print the job object now, I see
Ganga In [11]: j.outputfiles
Ganga Out [11]: [LocalFile(namePattern='*.txt', localDir='')]
so the wildcard is still there. When I now submit the job and look at it after it has completed, I see something different
j.submit()
# wait
Ganga In [17]: j.outputfiles
Ganga Out [17]: [LocalFile(namePattern='abcd.txt', localDir='/home/egede/gangadir/workspace/egede/LocalXML/3/output')]
so you see that it now shows the actual file that was created and not the wildcard. However, if I copy the job (to create a new one)
j = j.copy()
Ganga In [18]: j.outputfiles
Ganga Out [18]: [LocalFile(namePattern='*.txt', localDir='')]
you see that the wildcard is back. This is the correct behaviour (i.e. the new job is a copy of the unsubmitted one).
I do not believe that your change here will have that behaviour. I am not sure if we have tes cases for this, but I will start them now.
|
As expected, the testing indeed shows that there now are multiple errors related to the use of wildcards for |
|
While running Gangacore/test/Unit and Gangacore/test/GPI same test cases fail with or without these changes. I think we need to research more into it. |
egede
left a comment
There was a problem hiding this comment.
I do not think this latest change will work neither. In the last of your examples, the outputfiles should have "resolved" the wildcard and showed abcd.txt instead.
fixes: #2190
Job output files can now be extended dynamically.