Skip to content

Fix for #126 as initially proposed by @bbrangeo; pushing for speed (since i need it.. :) )#127

Merged
CecSve merged 1 commit intogbif:masterfrom
lucbettaieb:luc/fix-caching
Mar 1, 2024
Merged

Fix for #126 as initially proposed by @bbrangeo; pushing for speed (since i need it.. :) )#127
CecSve merged 1 commit intogbif:masterfrom
lucbettaieb:luc/fix-caching

Conversation

@lucbettaieb
Copy link
Copy Markdown
Contributor

Description

Fixes #126 with changes proposed by @bbrangeo

Related Issue

Fixes #126

Example

@lucbettaieb lucbettaieb marked this pull request as ready for review February 29, 2024 13:54
@lucbettaieb lucbettaieb mentioned this pull request Feb 29, 2024
@lucbettaieb
Copy link
Copy Markdown
Contributor Author

lucbettaieb commented Feb 29, 2024

Tested locally:

Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pygbif
>>>

Also tested with my code that uses "occurrences".

@lucbettaieb
Copy link
Copy Markdown
Contributor Author

Thanks @CecSve !

@airnst
Copy link
Copy Markdown

airnst commented Mar 1, 2024

Sorry to ask here, but does anyone happen to know when the update will be released to make new installations work?

@lucbettaieb
Copy link
Copy Markdown
Contributor Author

@airnst Not sure, but if you are blocked you can install from source with pip:

pip install git+https://github.com/gbif/pygbif.git@master

i think that should work...

@abubelinha
Copy link
Copy Markdown

I am not sure but I think this fix raised a new problem see #145
The specific error line was one introduced in this fix.
If I downgrade to pygbif==0.6.3 it fixes #145

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.17%. Comparing base (59960ff) to head (c8e4c8d).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
pygbif/caching.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   80.00%   80.17%   +0.17%     
==========================================
  Files          26       26              
  Lines         675      671       -4     
==========================================
- Hits          540      538       -2     
+ Misses        135      133       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot import name 'remove_expired_responses' from 'requests_cache'

5 participants