add progress bar to download_get#122
Open
dluks wants to merge 2 commits intogbif:masterfrom
Open
Conversation
Contributor
Author
|
When adding |
Contributor
|
@dluks thanks for adding this. I am a little reluctant to add a dependency for just this functionality. Would it be possible to make it more opt in with perhaps an extra arg for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a simple
tqdmprogress bar to thegbif_GET_writefunction as a quality-of-life improvement.Description
I often need to download large files from GBIF and have wished I could see the progress. This addresses that. I don't know what the sentiment is toward requirements on this project, so I hope the inclusion of
tqdmisn't against principle.Example
All tests continue to pass, but, given the minimal testing of
download_getat present, I didn't add anything. I'm not exactly sure how I'd test this anyway 🤔 .