fixes for handling geometry predicate in occurrences.download#84
Merged
fixes for handling geometry predicate in occurrences.download#84
Conversation
- bump package version - add a test for adding geometry via a string rather than via add_geometry - (unrelated: also remove response header content-type check in gbif_GET_write because ctype has changed)
Member
|
No comments from me 😊 |
Collaborator
Author
|
thanks @peterdesmet |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 81.55% 81.77% +0.21%
==========================================
Files 26 26
Lines 629 631 +2
==========================================
+ Hits 513 516 +3
+ Misses 116 115 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #81
@stijnvanhoey @niconoe @peterdesmet if you have a chance, any thoughts on this change? If not worries, and i'll merge soon