cherry pick changes made by Peter Young on the ghost branch#84
cherry pick changes made by Peter Young on the ghost branch#84
Conversation
| run: mvn clean install | ||
| - name: Build rpm | ||
| run: mvn -Pproduction install | ||
| run: mvn -DskipTests -Pproduction install |
There was a problem hiding this comment.
Do we remove the functionality of checking the tests before creating the RPM?
There was a problem hiding this comment.
Right, we should revert this change
|
|
||
| if (configPathSet.isEmpty()) { | ||
| LOG.info("Action " + action + " has empty path set, respond NOANSWER"); | ||
| LOG.info("Action action ID " + action.getId() + " has empty path set, respond NOANSWER"); |
There was a problem hiding this comment.
Should it be a LOG.warning?
| //in this case, the loop is aborted, since this action is not completed yet, | ||
| //so we have to keep waiting. | ||
| action = null; | ||
| //action = null; |
There was a problem hiding this comment.
I wonder if this change will have an impact on behaviour, as previously it seems that abortions were performed and the wait was not continued. Could you provide a little more information about the consequences of this change?
There was a problem hiding this comment.
This is the code running ghost at the moment. action is a local value and we we are not inside a loop, the effect of that line should be irrelevant. but make me wonder why it was like that earlier.
|
I have reviewed the PR and it looks fine to me, except that if you could give more information about this line |
See #81