Skip to content

REL-4792 Added 10s delay after F2 observe. #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jluhrs merged 1 commit into from
Apr 2, 2026
Merged

REL-4792 Added 10s delay after F2 observe. #2818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions modules/server/src/main/scala/seqexec/server/flamingos2/Flamingos2ControllerEpics.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@ package seqexec.server.flamingos2

import java.util.concurrent.TimeUnit.MILLISECONDS
import java.util.concurrent.TimeUnit.SECONDS

import scala.concurrent.duration.FiniteDuration

import scala.concurrent.duration.{ Duration, FiniteDuration }
import cats.data.StateT
import cats.effect.Async
import cats.effect.{ Async, Temporal }
import cats.syntax.all._
import edu.gemini.spModel.gemini.flamingos2.Flamingos2.Decker
import edu.gemini.spModel.gemini.flamingos2.Flamingos2.Filter
Expand All @@ -29,6 +27,8 @@ import seqexec.server.flamingos2.Flamingos2Controller._
import squants.Time
import squants.time.TimeConversions._

import java.util.concurrent.TimeUnit

trait Flamingos2Encoders {
implicit val encodeReadoutMode: EncodeEpicsValue[ReadoutMode, String] = EncodeEpicsValue {
case ReadoutMode.SCIENCE => "SCI"
Expand Down Expand Up @@ -156,10 +156,14 @@ object Flamingos2ControllerEpics extends Flamingos2Encoders {
_ <- L.debug("Completed Flamingos2 configuration")
} yield ()

private val paddingDelay: Duration = Duration(10.0, TimeUnit.SECONDS)
override def observe(fileId: ImageFileId, expTime: Time): F[ObserveCommandResult] = for {
_ <- L.debug(s"Send observe to Flamingos2, file id $fileId")
_ <- sys.observeCmd.setLabel(fileId)
_ <- sys.observeCmd.post(FiniteDuration(expTime.toMillis, MILLISECONDS) + ReadoutTimeout)
_ <-
L.debug(s"Flamingos2 reports observe completion. Start delay of $paddingDelay for REL-4792")
_ <- Temporal[F].sleep(paddingDelay)
_ <- L.debug("Completed Flamingos2 observe")
} yield ObserveCommandResult.Success

Expand Down
Loading