Merged
Conversation
Fixed: 1. Updating folder itself on collapse 2. Spacing of files when MinimumFolderIcons is false
Owner
|
Thanks for your hard work on this! Your code looks nicely done at a glance, and I'll be testing this soon to check how it works visually. Stay tuned. ✨ |
kotaindah55
added a commit
to kotaindah55/iconic
that referenced
this pull request
May 17, 2025
Owner
|
Finished testing! This PR resolves both issues you've linked, and you've tied the indentation to minimal mode really smoothly. The sudden icon shift might surprise people who've just installed the plugin, so I'll probably set I only need you to tweak a few comments, since reading this function does take some brainpower:
Update the branch any way you like, and I'll merge it as one commit. 🙏 |
fix: support newlines in splitFilePath()
Contributor
Author
|
Should be good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two main bugs addressed are both within the file manager.
Icon for open folder does not revert to closed folder when folder is closed #94
This version overrides the optimizer for specifically only the folder being collapsed, updating the switch between open and closed states.
Align files with folders when using arrows in file/folder view #112
This version fixes the alignment issues present when "Minimal Folder Icons" is disabled. The new alignment is consistent with vanilla Obsidian.
Known Issues