Skip to content

fix: fix for newlines in filename#86

Merged
gfxholo merged 1 commit intogfxholo:mainfrom
johannrichard:fix-for-filename-with-newlines
Jun 9, 2025
Merged

fix: fix for newlines in filename#86
gfxholo merged 1 commit intogfxholo:mainfrom
johannrichard:fix-for-filename-with-newlines

Conversation

@johannrichard
Copy link
Copy Markdown
Contributor

@johannrichard johannrichard commented Feb 16, 2025 •
edited
Loading

FIXES: #49

How to test:

  • Install beta version with BRAT as a frozen version (johannrichard/iconic / 1.1.2-beta.1) 📦
  • Create a file with a linebreak (see below how to do this) and add some content
  • Enable Iconic ✔️ (and optionally add an icon for the file with a line break)
  • Error is gone ✨
$ cd YOUR/OBSIDIAN/VAULT
$ touch "Filename with 
a line break.md"

@gfxholo
Copy link
Copy Markdown
Owner

gfxholo commented Feb 16, 2025

I'm reeeeally going to enjoy testing this if I get time tomorrow. Single-character fixes are the funniest contributions. I appreciate you figuring this one out, and I hope it's the actual cause of @HishamAbraham's error too :)

@gfxholo gfxholo self-assigned this Jun 9, 2025
@gfxholo gfxholo added the bug Something isn't working label Jun 9, 2025
@gfxholo gfxholo merged commit 152211b into gfxholo:main Jun 9, 2025
@gfxholo
Copy link
Copy Markdown
Owner

gfxholo commented Jun 9, 2025

Several tomorrows later... it works great, Johann! 💜

Multiline filenames are being \n-escaped safely inside data.json, so this should be a stable fix :]

@gfxholo gfxholo added this to the 1.1.2 milestone Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gfxholo gfxholo

Labels

bug Something isn't working

Projects

None yet

Milestone

1.1.2

Development

Successfully merging this pull request may close these issues.

[bug] Cannot read properties of undefined

2 participants

@johannrichard @gfxholo