Skip to content

ci: remove duplicate benchmark handling and update benchmark action version#4108

Merged
ReneWerner87 merged 4 commits intomainfrom
check_benchmark_deduplication
Mar 5, 2026
Merged

ci: remove duplicate benchmark handling and update benchmark action version#4108
ReneWerner87 merged 4 commits intomainfrom
check_benchmark_deduplication

Conversation

@ReneWerner87
Copy link
Copy Markdown
Member

@ReneWerner87 ReneWerner87 commented Feb 24, 2026

Copilot AI review requested due to automatic review settings February 24, 2026 12:02
@ReneWerner87 ReneWerner87 requested a review from a team as a code owner February 24, 2026 12:02
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Feb 24, 2026

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 24, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .github/workflows/benchmark.yml is excluded by !**/*.yml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bdba98b6-ee33-400e-b571-77499d986473

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch check_benchmark_deduplication

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ReneWerner87 ReneWerner87 added this to v3 Feb 24, 2026
@ReneWerner87 ReneWerner87 added this to the v3 milestone Feb 24, 2026
@ReneWerner87 ReneWerner87 mentioned this pull request Feb 24, 2026
Merged
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.03%. Comparing base (92c506a) to head (f6f5e4a).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4108      +/-   ##
==========================================
- Coverage   91.04%   91.03%   -0.02%     
==========================================
  Files         119      119              
  Lines       11385    11385              
==========================================
- Hits        10366    10364       -2     
- Misses        647      648       +1     
- Partials      372      373       +1
Flag Coverage Δ
unittests 91.03% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI reviewed Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a manual workaround for handling duplicate benchmark names in Go benchmarks and updates the benchmark action to use a version that includes native support for this functionality via the go-force-package-suffix option. The change simplifies the workflow by eliminating ~30 lines of complex awk-based preprocessing.

Changes:

  • Removed manual awk-based duplicate benchmark name handling workaround (4 steps, ~30 lines)
  • Updated benchmark-action/github-action-benchmark from v1.20.7 to commit from PR #337
  • Added go-force-package-suffix: true parameter to all three benchmark action invocations

Comment thread .github/workflows/benchmark.yml Outdated
@ReneWerner87 ReneWerner87 marked this pull request as draft February 24, 2026 20:12
@ReneWerner87
Copy link
Copy Markdown
Member Author

ReneWerner87 commented Mar 4, 2026

upstream PR was merged

@ReneWerner87 ReneWerner87 marked this pull request as ready for review March 5, 2026 07:15
@ReneWerner87 ReneWerner87 merged commit 7595d36 into main Mar 5, 2026
19 of 20 checks passed
@ReneWerner87 ReneWerner87 deleted the check_benchmark_deduplication branch March 5, 2026 07:33
@github-project-automation github-project-automation Bot moved this to Done in v3 Mar 5, 2026
@ReneWerner87 ReneWerner87 modified the milestones: v3, v3.2.0 Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@gaby gaby Awaiting requested review from gaby gaby is a code owner automatically assigned from gofiber/maintainers

@sixcolors sixcolors Awaiting requested review from sixcolors sixcolors is a code owner automatically assigned from gofiber/maintainers

@efectn efectn Awaiting requested review from efectn efectn is a code owner automatically assigned from gofiber/maintainers

Assignees

No one assigned

Labels

🧹 Updates v3

Projects

v3
Status: Done

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ReneWerner87