[dslx] Allow for/unroll_for expressions as operands in binary operations#4152
Open
anishesg wants to merge 1 commit intogoogle:mainfrom
Open
[dslx] Allow for/unroll_for expressions as operands in binary operations#4152anishesg wants to merge 1 commit intogoogle:mainfrom
for/unroll_for expressions as operands in binary operations#4152anishesg wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
5017665 to
431679c
Compare
richmckeever
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3967
Parsing an inline
forexpression as the RHS of a binary operation (e.g.,p ^ for (i, acc) in u32:0..u32:8 { ... }(u1:1)) produced a spurious parse error:The DSLX parser's
ParseTermLhsfunction handles several keyword-prefixed sub-expressions (if,const if,const for,const match,match) but was missing cases for plainforandunroll_for. When descending intoParseTermLhsto parse the RHS of a binary operator, encountering aforkeyword hit the fallthrough error case.The fix adds
kFor/kUnrollForhandling toParseTermLhs, consistent with how the same keywords are already handled inParseExpressionfor top-level expressions.forandunroll_forkeyword cases toParseTermLhsto callParseFordirectlyForExpressionAsRhsOfBinopthat round-tripsp ^ for (...) in ... { ... }(...)