test_constexpr_rollover_warning test was failing, because constant_collector evaluated and noted constexpr value for Binop without rollover warning before evaluator.cc had a chance to do it. I've had to follow the workaround used here. After fixing that test case, I've removed the draft state and the pull request is now ready for review.

I've rebased changes on latest main, so Continuous Integration job will now succeed.

Thanks for the review! I've applied your suggestion.

I've added more descriptive error log. See review comment.

Merging #3931 should help with the failing Test ZSTD module job.

This is failing internal tests; the DSLX index is correctly a const (it's the index in an unroll for) but the new check is claiming it's not a const.

This is failing internal tests; the DSLX index is correctly a const (it's the index in an unroll for) but the new check is claiming it's not a const.

@dplassgit the check is based on confirming that the index value is a known const, so I suspect that constant collector couldn't collect the value before the check (it was a similar case with Binop) or the used type info object is incorrect. Can you help me identify which AST node was used as the index?

It looks something like this (partially redacted)

 let v =
            unroll_for! (st_slot_idx, store_data_value): (
                u32, common::dv[NS][NV]
            ) in u32:0..NV {
                let (_, sdv) = recv_if(
                    tok, channel_array[st_slot_idx],  // <<< failing on st_slot_idx
                    ready,
                    zero!<...>());
            }(zero!<...>());

Hey @dplassgit ,
the code sample you've provided doesn't seem sufficient to reproduce the error you're seeing in the test.
I've created a proc with a similar unroll_for and channel array access, but I haven't found a way to trigger the error here.
Is there a chance you can provide more information or a minimal reproducible example with the error?

@dplassgit you can find our attempt to reproduce your failing test case in this commit in our fork.

I've rebased changes onto the latest main, so Test ZSTD module should pass now and changed instance of for to const for in zstd_dec_test.x which also triggered the dynamic indexing error.

Re-approving to run internal checks.