Allow selection of verbosity level for vtrace_fmt! messages#3932
Open
joannabrozek wants to merge 20 commits intogoogle:mainfrom
Open
Allow selection of verbosity level for vtrace_fmt! messages#3932joannabrozek wants to merge 20 commits intogoogle:mainfrom
vtrace_fmt! messages#3932joannabrozek wants to merge 20 commits intogoogle:mainfrom
Conversation
max_trace_verbosity flag vtrace_fmt! messages
983deff to
5bd314f
Compare
5bd314f to
656fb31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for excluding
vtrace_fmt!messages according tomax_trace_verbosityflag for:DSLX interpreter:
max_trace_verbosityflag with the default value set to 100 (seexls/dslx/interpreter_main.cc)verbosity_to theTraceDataclass to be able to pass the verbosity ofvtrace_fmt!()messages (seexls/dslx/bytecode/bytecode.h)max_trace_verbosityflag propagation usingBytecodeInterpreterOptionsto the bytecode interpreter, where the vtrace messages are filtered (seexls/dslx/bytecode/bytecode_interpreter.cc)vtrace_fmt!()(seexls/dslx/bytecode/bytecode_interpreter_test.cc)IR interpreter:
emit_positionsflag, which is enabled by default, as it was previously hardcoded as enabled as well - seexls/dslx/ir_convert/ir_converter_main.cc)trace_fmt!()andvtrace_fmt!()(see thexls/dslx/run_routines/run_routines.ccfile)SourceInfoinsideTraceso that the displayed logs include information about which file they came from and their location (row and column) - seexls/dslx/ir_convert/function_converter.ccxls/dslx/interpreter_test.pyDslxInterpreterEventspointer and populating it (seexls/dslx/run_routines/run_routines.ccandxls/dslx/run_routines/ir_test_runner.cc)vtrace_fmt!()messages filtering (seexls/interpreter/ir_interpreter.cc)xls/interpreter/ir_evaluator_test_base.cc)JIT and AOT:
max_trace_verbosity_to theEvaluatorOptionsandJitEvaluatorOptionsclasses to be able to propagate themax_trace_verbosityflag (seexls/interpreter/evaluator_options.handxls/jit/jit_evaluator_options.h)max_trace_verbosityflag and passed it usingJitEvaluatorOptions(seexls/jit/aot_compiler_main.cc)max_trace_verbosityflag propagation usingEvaluatorOptionsfor function and block wrappers (seexls/jit/jit_function_wrapper_cc.tmpl,xls/jit/function_base_jit_wrapper.handxls/jit/block_base_jit_wrapper.h)vtrace_fmt!()messages filtering (seexls/jit/jit_callbacks.cc)xls/examples/vtrace_fmt.x,xls/examples/vtrace_fmt_block_jit_test.cc,xls/examples/vtrace_fmt_jit_test.cc,xls/examples/vtrace_fmt_proc_jit_test.cc)xls/jit/function_jit.cc) and a test (seexls/jit/function_jit_test.cc)xls/jit/block_jit.cc) and updated the test (seexls/interpreter/block_evaluator_test_base.cc)xls/jit/proc_jit.cc) and a test (seexls/interpreter/proc_evaluator_test_base.cc)xls/jit/function_jit_aot_test.cc)eval_ir_main tool:
max_trace_verbosityflag and passed it usingJitEvaluatorOptions(seexls/tools/eval_ir_main.cc)xls/tools/eval_ir_main_test.py)eval_proc_main tool:
max_trace_verbosityflag and passed it usingBlockEvaluator(seexls/tools/eval_proc_main.cc)xls/tools/eval_proc_main_test.py)codegen_main tool:
max_trace_verbosityflag propagation (addressing the issue: Mismatch betweenmax_trace_verbosityandvtrace_fmt!codegen output #3080) - seexls/tools/codegen.ccandxls/tools/codegen_flags.ccxls/tools/codegen_main_test.py)