Skip to content
This repository was archived by the owner on Apr 17, 2026. It is now read-only.

Add structure to project and global calibanconfig schema#56

Merged
sritchie merged 2 commits intomasterfrom
sritchie/separate_config
Jul 24, 2020
Merged

Add structure to project and global calibanconfig schema#56
sritchie merged 2 commits intomasterfrom
sritchie/separate_config

Conversation

@sritchie
Copy link
Copy Markdown
Contributor

@sritchie sritchie commented Jul 24, 2020

This PR paves the way for project, user and shared configurations across Caliban builds.

s.Optional("apt_packages", default=AptPackages.validate({})):
AptPackages,
# If present, Caliban will attempt to install Julia into the base container.
s.Optional("julia_version", default=None):
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's for you, @eschnett . I'll open up a separate PR that integrates your Julia work into caliban.build and pulls the version from this key. What do you think?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 24, 2020

Codecov Report

Merging #56 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   50.62%   50.60%   -0.02%     
==========================================
  Files          28       28              
  Lines        2894     2897       +3     
==========================================
+ Hits         1465     1466       +1     
- Misses       1429     1431       +2     
Impacted Files Coverage Δ
caliban/config/__init__.py 100.00% <100.00%> (ø)
caliban/platform/gke/util.py 71.92% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a9d0b...f124926. Read the comment docs.

@sritchie sritchie merged commit 0bd5667 into master Jul 24, 2020
@sritchie sritchie deleted the sritchie/separate_config branch July 24, 2020 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant