Skip to content

Flip default value of allow_imports to False in Fiddle's absl_flags. #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Flip default value of allow_imports to False in Fiddle's absl_flags. #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fiddle/_src/absl_flags/flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def __init__(
self,
*args,
default_module: Optional[types.ModuleType] = None,
allow_imports: bool = True,
allow_imports: bool = False,
pyref_policy: Optional[serialization.PyrefPolicy] = None,
**kwargs,
):
Expand Down Expand Up @@ -289,7 +289,7 @@ def DEFINE_fiddle_config( # pylint: disable=invalid-name
pyref_policy: Optional[serialization.PyrefPolicy] = None,
flag_values: flags.FlagValues = flags.FLAGS,
required: bool = False,
allow_imports: bool = True,
allow_imports: bool = False,
) -> flags.FlagHolder[Any]:
r"""Declare and define a fiddle command line flag object.

Expand Down
2 changes: 1 addition & 1 deletion fiddle/_src/absl_flags/sweep_flag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def __init__(
required: bool = False,
help: str = "Multi-flag for a fiddle config sweep.", # pylint: disable=redefined-builtin
default_module: Optional[types.ModuleType] = None,
allow_imports: bool = True,
allow_imports: bool = False,
):
self.name = name
self._allow_imports = allow_imports
Expand Down
2 changes: 1 addition & 1 deletion fiddle/_src/absl_flags/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ def resolve_function_reference(
def init_config_from_expression(
expression: str,
module: Optional[types.ModuleType] = None,
allow_imports: bool = True,
allow_imports: bool = False,
) -> config.Buildable:
"""Initializes a `fdl.Buildable` from a function call expression.

Expand Down
Loading