fix!: Change id from int64 to string in ActivityService.MarkThreadDone#4056
Merged
gmlewis merged 1 commit intogoogle:masterfrom Mar 2, 2026
Merged
Conversation
Contributor
|
LGTM |
ActivityService.MarkThreadDone accepts string idActivityService.MarkThreadDone accepts string id
ActivityService.MarkThreadDone accepts string idid from int64 to string in ActivityService.MarkThreadDone
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4056 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 208 208
Lines 19248 19248
=======================================
Hits 18112 18112
Misses 938 938
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Mar 2, 2026
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear and @munlicode!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
ActivityService.MarkThreadDoneacceptsstringidinstead ofint64.This is for consistency with
GetThread,MarkThreadRead,GetThreadSubscription, which all accept an id asstringand notint64.ListNotificationsandListRepositoryNotificationsreturnNotificationwithIDasstring.Fixes #3269