feat: Add Issue Dependencies API support by tommaso-moro · Pull Request #4130 · google/go-github

tommaso-moro · 2026-04-02T14:09:38Z

closes: #4129

Add Issue Dependencies API support

Add support for the Issue Dependencies REST API.

Changes

New file github/issues_dependencies.go adds four methods to IssuesService:

Method	Endpoint	Description
`ListBlockedBy`	`GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by`	List dependencies blocking an issue
`AddBlockedBy`	`POST /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by`	Add a blocking dependency
`RemoveBlockedBy`	`DELETE /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by/{issue_id}`	Remove a blocking dependency
`ListBlocking`	`GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocking`	List issues this issue is blocking

Also adds IssueDependencyRequest type used by AddBlockedBy.

Testing

Full test coverage in github/issues_dependencies_test.go (12 tests) using standard helpers: testBadOptions, testNewRequestAndDoFailure, testURLParseError, testJSONMarshal.

Auto-generated files updated via go generate: accessors, accessor tests, iterators, and iterator tests.

All scripts pass: script/fmt.sh, script/test.sh, script/lint.sh.

Add four new methods to IssuesService for the Issue Dependencies REST API (apiVersion 2026-03-10): - ListBlockedBy: list dependencies blocking an issue - AddBlockedBy: add a blocking dependency to an issue - RemoveBlockedBy: remove a blocking dependency - ListBlocking: list issues that an issue is blocking Includes IssueDependencyRequest type, full test coverage with testBadOptions, testNewRequestAndDoFailure, testURLParseError, and testJSONMarshal helpers.

Run go generate to add: - GetIssueID accessor for IssueDependencyRequest - ListBlockedBy and ListBlocking iterators with tests

google-cla · 2026-04-02T14:09:50Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

codecov · 2026-04-02T14:18:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.73%. Comparing base (f12c950) to head (dfd8467).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4130      +/-   ##
==========================================
+ Coverage   93.70%   93.73%   +0.02%     
==========================================
  Files         210      211       +1     
  Lines       19745    19825      +80     
==========================================
+ Hits        18502    18582      +80     
  Misses       1047     1047              
  Partials      196      196

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis

Thank you, @tommaso-moro!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode

tommaso-moro · 2026-04-08T09:12:21Z

@Not-Dhananjay-Mishra thank you for the review! I have addressed the points you raised and updated this branch.

Co-authored-by: Oleksandr Redko <[email protected]>

…dependencies.go Co-authored-by: Oleksandr Redko <[email protected]>

Co-authored-by: Oleksandr Redko <[email protected]>

Per review feedback: both issue_id and issue_number are integer in the OpenAPI spec, so issueNumber should be int64 for consistency.

gmlewis · 2026-04-23T14:17:33Z

@tommaso-moro - please fix the broken tests before we proceed.

tommaso-moro · 2026-04-24T14:15:11Z

+	// Stringify always prints non-pointer value fields (ints, strings, etc.) but
+	// skips nil pointers/slices/maps, so only structs containing non-pointer
+	// value fields need an entry here.
+	namedStructZeroStr = map[string]string{


This map must be kept in sync with the struct definitions manually, not sure if fine for now but open to suggestions for a better approach!

If you revert all the changes made to gen-stringify-test.go, what exactly breaks?

If it is simply the formatting in a unit test, then I would say that I would rather update those broken unit tests than to make a new map of special special cases in gen-strigify-test.go.

gmlewis

Sorry, @tommaso-moro - but I'm not OK with the changes to gen-stringify-test.go that were made since my last code review (and prior approval).

There should be no reason to add this extra maintenance burden to this code.

I'm going to have to go through all the comments and try to figure out why you added this.

tommaso-moro added 2 commits April 2, 2026 11:27

chore: Regenerate accessors and iterators

9aba995

Run go generate to add: - GetIssueID accessor for IssueDependencyRequest - ListBlockedBy and ListBlocking iterators with tests

tommaso-moro mentioned this pull request Apr 2, 2026

Add support for Issue Dependencies REST API #4129

Open

tommaso-moro marked this pull request as ready for review April 2, 2026 14:46

chore: trigger CI

f57a237

gmlewis approved these changes Apr 2, 2026

View reviewed changes

gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 2, 2026

Not-Dhananjay-Mishra reviewed Apr 3, 2026

View reviewed changes

Comment thread github/issues_dependencies.go Outdated

Comment thread github/issues_dependencies.go Outdated

Comment thread github/issues_dependencies.go Outdated

tommaso-moro and others added 4 commits April 3, 2026 11:49

remove omitempty for required param

76cfab3

pass by value instead of reference as param is required

4550de5

add missing fields to Issue struct

13f260e

Merge branch 'master' into tommy/issue-dependencies-support

14b279b

tommaso-moro requested review from Not-Dhananjay-Mishra and gmlewis April 8, 2026 09:11

munlicode approved these changes Apr 8, 2026

View reviewed changes

alexandear reviewed Apr 8, 2026

View reviewed changes

Comment thread github/issues.go Outdated

alexandear suggested changes Apr 8, 2026

View reviewed changes

tommaso-moro and others added 10 commits April 9, 2026 10:11

use any instead of interface{}

6fd4bfd

Co-authored-by: Oleksandr Redko <[email protected]>

Use int64 instead of *int64 for IssueID

171deba

Co-authored-by: Oleksandr Redko <[email protected]>

Update number param to issueNumber for consistency, in github/issues_…

c5e05bf

…dependencies.go Co-authored-by: Oleksandr Redko <[email protected]>

Update number param to issueNumber in github/issues_dependencies.go

1d84d92

Co-authored-by: Oleksandr Redko <[email protected]>

update number param to issueNumber

a3c6983

fix tests now that IssueID is of type int64

45fb09c

update number param to issueNumber

1e86822

Use int64 for issueNumber parameter

0000b64

Per review feedback: both issue_id and issue_number are integer in the OpenAPI spec, so issueNumber should be int64 for consistency.

clean up test

d261d4f

Merge branch 'master' into tommy/issue-dependencies-support

f4e9158

tommaso-moro requested a review from alexandear April 9, 2026 10:22

alexandear approved these changes Apr 9, 2026

View reviewed changes

Comment thread github/issues.go Outdated

Comment thread github/issues.go Outdated

Comment thread github/issues.go Outdated

Comment thread github/issues.go Outdated

Comment thread github/issues.go Outdated

Not-Dhananjay-Mishra reviewed Apr 9, 2026

View reviewed changes

Comment thread github/issues_dependencies.go Outdated

gmlewis added the waiting for reply label Apr 11, 2026

tommaso-moro added 3 commits April 20, 2026 16:11

Merge branch 'master' into tommy/issue-dependencies-support

394a89c

fix types

23de54e

use shorthand or types

8f1e865

gmlewis removed the waiting for reply label Apr 20, 2026

tommaso-moro added 2 commits April 20, 2026 16:32

go generate

f4515f7

go generate

f207870

gmlewis added the waiting for reply label Apr 23, 2026

tommaso-moro added 2 commits April 24, 2026 14:55

fix tests

ed9d275

Merge branch 'master' into tommy/issue-dependencies-support

7f3990f

tommaso-moro commented Apr 24, 2026

View reviewed changes

tommaso-moro requested review from Not-Dhananjay-Mishra and alexandear April 24, 2026 15:07

Merge branch 'master' into tommy/issue-dependencies-support

dfd8467

gmlewis removed the waiting for reply label Apr 24, 2026

gmlewis requested changes Apr 24, 2026

View reviewed changes

Conversation

tommaso-moro commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Issue Dependencies API support

Changes

Testing

Uh oh!

google-cla Bot commented Apr 2, 2026

Uh oh!

codecov Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tommaso-moro commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis commented Apr 23, 2026

Uh oh!

tommaso-moro Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gmlewis Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tommaso-moro commented Apr 2, 2026 •

edited

Loading

codecov Bot commented Apr 2, 2026 •

edited

Loading

tommaso-moro Apr 24, 2026 •

edited

Loading