Check useUnsafe before usePrealloc in TapeMachine exec#579
Open
eric wants to merge 1 commit intogorgonia:masterfrom
Open
Check useUnsafe before usePrealloc in TapeMachine exec#579eric wants to merge 1 commit intogorgonia:masterfrom
eric wants to merge 1 commit intogorgonia:masterfrom
Conversation
The non-CUDA TapeMachine exec switch checked usePrealloc (a runtime check for non-nil destination register) before instr.useUnsafe (a compile-time flag for shared input/output registers). When registers are shared, the destination always has a value (the input), so usePrealloc was always true, shadowing the useUnsafe case entirely. For ops that implement UnsafeDo but not UsePreallocDo (e.g. elemUnaryOp), this caused plain Do() to run instead of UnsafeDo(), allocating new memory rather than modifying in-place. This defeated the register sharing optimization. The CUDA execution path (vm_tape_cuda.go) has no usePrealloc case and already checks useUnsafe directly after preAllocated. This change aligns the non-CUDA path with the CUDA path's intended design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-CUDA TapeMachine exec switch checked usePrealloc (a runtime check for non-nil destination register) before instr.useUnsafe (a compile-time flag for shared input/output registers). When registers are shared, the destination always has a value (the input), so usePrealloc was always true, shadowing the useUnsafe case entirely.
For ops that implement UnsafeDo but not UsePreallocDo (e.g. elemUnaryOp), this caused plain Do() to run instead of UnsafeDo(), allocating new memory rather than modifying in-place. This defeated the register sharing optimization.
The CUDA execution path (vm_tape_cuda.go) has no usePrealloc case and already checks useUnsafe directly after preAllocated. This change aligns the non-CUDA path with the CUDA path's intended design.