fix: pin charset-normalizer to <3 to fix Big5 encoding detection (#1628)#1824
Open
parinporecha wants to merge 1 commit intohttpie:masterfrom
Open
fix: pin charset-normalizer to <3 to fix Big5 encoding detection (#1628)#1824parinporecha wants to merge 1 commit intohttpie:masterfrom
parinporecha wants to merge 1 commit intohttpie:masterfrom
Conversation
…pie#1628) charset-normalizer 3.x changed its detection algorithm, causing Big5-encoded Chinese text to be misdetected as johab (Korean). This breaks the test_terminal_output_response_charset_detection and test_terminal_output_request_charset_detection tests for Big5. Pin to charset-normalizer>=2.0.0,<3.0.0 until the upstream ranking regression is resolved. Fixes httpie#1628
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1824 +/- ##
==========================================
- Coverage 97.28% 94.11% -3.18%
==========================================
Files 67 113 +46
Lines 4235 7694 +3459
==========================================
+ Hits 4120 7241 +3121
- Misses 115 453 +338 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charset-normalizer 3.x changed its detection algorithm, causing Big5-encoded Chinese text to be misdetected as johab (Korean). This breaks the test_terminal_output_response_charset_detection and test_terminal_output_request_charset_detection tests for Big5.
Pin to charset-normalizer>=2.0.0,<3.0.0 until the upstream ranking regression is resolved.
Fixes #1628