Merged
Conversation
If bleak is running in a .app (e.g. created with py2app), then scanning in macOS 12 works as it did in previous versions, so we don't need to log the error. We can determine this by checking the bundle id since Python itself is a .app and has a bundle id. Related: #720
bytearray(val) will create a zero-filled instance of length val. bytearray([val]) will create a bytearray containing val.
bluezdbus: Return the battery percentage in an array
Skip logging CoreBlueooth scanner error if running as .app
Apple has fixed the bug in macOS that caused Bleak to be treated as a background app and not return scan results unless a service UUID was provided.
black finally has a stable release, so we shouldn't expect breaking changes for a year
Black is stable now, so we shouldn't have to do this again for a whole year.
Local device info object for pair/unpair
* Add a Multiple Device Troubleshooting Sections - Add information / tips to help with: - Connection issues to multiple devices - Pass more parameters to notify callback function Fixes #754
This fixes a leak of the future passed to _disconnect_futures in CentralManagerDelegate.disconnect(). As with other methods, this future is only valid for the duration of the method call. This was probably just a typo since _disconnect_callbacks also starts with _disconnect.
This removes the disconnect callback from self._disconnect_callbacks when a device disconnects. This ensures that the callback is not called more than once and that objects referenced by the callback are not leaked if the remote device initiates the disconnection and the disconnect method is never called.
This documents a couple of common macOS issues. Fixes #768
corebluetooth: suppress error message in macOS 12.3
docs/troubleshooting: common macOS issues
…ered the filters to match the bluez documentation.
…filters-bluez Adds filters Discoverable and Pattern to the Bluezdbus scanner.
Mac fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
DiscoverableandPatternto BlueZ D-Bus scanner. Fixes Adding the scan.pattern filter, introduced in Bluez 5.54 #790.Fixed
bytearrayon BlueZ >= 5.48. Fixes Cannot get the battery percentage using the bluez workaround (bluez >= 5.48) #750._disconnect_futuresinCentralManagerDelegate._disconnect_callbackson disconnect inCentralManagerDelegate.