luarocks opener: Call cfg.init() conditionally (fixes #29)#30
Draft
leso-kn wants to merge 1 commit intohishamhm:masterfrom
Draft
luarocks opener: Call cfg.init() conditionally (fixes #29)#30leso-kn wants to merge 1 commit intohishamhm:masterfrom
cfg.init() conditionally (fixes #29)#30leso-kn wants to merge 1 commit intohishamhm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #29.
@hishamhm I see there is some additional initialization of
luarocks.core.cfghappening in line 38 (cfg.init_package_paths).I grasp my implementation would conflict with this condition, as now
cfgwould always be initialized at this point?datafile/datafile/openers/luarocks.lua
Lines 33 to 42 in 52e43ad
Should I move
cfg.init_package_paths()up into the first if block?