Skip to content

Fix crash in macOS Tahoe #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inket merged 1 commit into from
Sep 17, 2025
Merged

Fix crash in macOS Tahoe #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions Sources/MBPopup/MBPopupExtensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,23 +38,31 @@ extension NSEvent {

extension NSStatusItem {
var realItem: NSStatusItem? {
if className == "NSStatusItem" {
if #available(macOS 15.0, *) {
return self
} else {
// In the case of an NSStatusItemReplicant (a replica for displaying the status item on inactive
// spaces/screens that happens to be an NSStatusItem subclass), we get the NSStatusItem that's being
// replicated from the property "parentItem".
return value(forKey: "parentItem") as? NSStatusItem
if className == "NSStatusItem" {
return self
} else {
// In the case of an NSStatusItemReplicant (a replica for displaying the status item on inactive
// spaces/screens that happens to be an NSStatusItem subclass), we get the NSStatusItem that's being
// replicated from the property "parentItem".
return value(forKey: "parentItem") as? NSStatusItem
}
}
}

var realWindow: NSWindow? {
if className == "NSStatusItem" {
if #available(macOS 15.0, *) {
return button?.window
} else {
// In the case of an NSStatusItemReplicant, we get the window from the property "window"
// as using button?.window will return the original status item's window.
return value(forKey: "window") as? NSWindow
if className == "NSStatusItem" {
return button?.window
} else {
// In the case of an NSStatusItemReplicant, we get the window from the property "window"
// as using button?.window will return the original status item's window.
return value(forKey: "window") as? NSWindow
}
}
}

Expand Down