feat(github-work-app): add reaction tooling to github mcp by miles-kt-inkeep · Pull Request #2130 · inkeep/agents

miles-kt-inkeep · 2026-02-18T18:58:29Z

No description provided.

vercel · 2026-02-18T18:58:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agents-api	Ready	Preview, Comment	Feb 18, 2026 8:52pm
agents-manage-ui	Ready	Preview, Comment	Feb 18, 2026 8:52pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
agents-docs	Skipped		Feb 18, 2026 8:52pm

changeset-bot · 2026-02-18T18:58:34Z

🦋 Changeset detected

Latest commit: 588a1dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@inkeep/agents-work-apps	Major
@inkeep/agents-api	Major
@inkeep/agents-manage-ui	Major
@inkeep/agents-cli	Major
@inkeep/agents-core	Major
@inkeep/agents-mcp	Major
@inkeep/agents-sdk	Major
@inkeep/ai-sdk-provider	Major
@inkeep/create-agents	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

claude

PR Review Summary

(11) Total Issues | Risk: High

🔴❗ Critical (5) ❗🔴

Inline Comments:

🔴 Critical: utils.ts:1017 Wrong API method name — deleteForPullRequestComment should be deleteForPullRequestReviewComment
🔴 Critical: utils.ts:104 Non-null assertion on reaction.user!.login crashes on deleted users
🔴 Critical: utils.ts:136 Same null safety issue as line 104
🔴 Critical: schemas.ts:26-30 Missing id field makes remove-comment-reaction unusable
🔴 Critical: utils.ts:601-603 Breaking change to generatePrMarkdown output format (markdown → JSON)

🟠⚠️ Major (5) 🟠⚠️

🟠 1) scope Missing unit tests for new reaction functions

Issue: Six new utility functions were added (createIssueCommentReaction, deleteIssueCommentReaction, createPullRequestReviewCommentReaction, deletePullRequestReviewCommentReaction, fetchIssueCommentReactions, fetchReviewCommentReactions) with no corresponding tests. Existing tests in utils.test.ts cover similar functions.

Why: The tests reviewer identified a potential bug (deleteForPullRequestComment vs deleteForPullRequestReviewComment) that would have been caught by unit tests. Missing test coverage allows regressions and API contract violations to ship.

Fix: Add unit tests following the existing patterns in packages/agents-work-apps/src/__tests__/github/mcp/utils.test.ts. At minimum, test:

Correct Octokit API method calls with proper parameters
Return value extraction (id, content)
Error propagation
Null user handling

Refs:

Existing test patterns

🟠 2) scope Missing documentation for new MCP tools

Issue: Two new MCP tools (add-comment-reaction, remove-comment-reaction) are added but no customer-facing documentation exists. The GitHub MCP server currently provides 12+ tools with no tool-level documentation.

Why: Customers cannot discover these capabilities or understand how to use them. The comment_type parameter distinguishing issue_comment vs review_comment is particularly non-obvious without docs.

Fix: Add documentation for the GitHub MCP server tools, either as a new guide page or within the existing MCP documentation. Document:

Available tools and their purposes
Parameters (especially comment_type enum values and valid reactions)
That add-comment-reaction returns a reaction_id needed for removal

Refs:

Existing MCP docs

Inline Comments:

🟠 Major: index.ts:1044-1066 Missing 403 error handling for add-comment-reaction
🟠 Major: index.ts:1135 Missing 403 error handling for remove-comment-reaction
🟠 Major: utils.ts:452-456 Reactions fetch not wrapped in try-catch — failures crash entire operation
🟠 Major: utils.ts:486-490 Same try-catch issue for review comment reactions
🟠 Major: .changeset:2 Changeset should be minor (breaking change), not patch

🟡 Minor (1) 🟡

Inline Comments:

🟡 Minor: index.ts:1006 Missing .describe() on reaction parameter

💭 Consider (1) 💭

💭 1) index.ts:1001-1005 comment_type enum naming

Issue: The comment_type enum values use GitHub API internal terminology (issue_comment, review_comment) which may confuse users unfamiliar with GitHub's API structure.

Why: From a customer perspective, both are "PR comments" — one is a general comment, one is an inline code comment. More intuitive values like general/inline or pr_comment/code_comment could improve discoverability.

Fix: Consider renaming the enum values and explaining the mapping in the description. This is a preference — the current values are technically accurate.

🚫 REQUEST CHANGES

Summary: This PR adds valuable reaction tooling but has several critical issues that need addressing before merge:

Bug: Wrong API method name (deleteForPullRequestComment → deleteForPullRequestReviewComment) will cause runtime failures
Broken workflow: Missing id field in ReactionSchema makes remove-comment-reaction unusable
Breaking change: generatePrMarkdown output format changed from human-readable markdown to JSON — this appears unintentional and will break existing tests and consumers
Null safety: Non-null assertions on reaction.user will crash on deleted accounts
Missing tests: New functions lack coverage

I recommend addressing the critical issues (especially the API method name bug and the generatePrMarkdown change) before merging.

Discarded (3)

Location	Issue	Reason Discarded
`schemas.ts:26-30`	`ReactionSchema.user` could use `GitHubUserSchema` for consistency with `CommentSchema.author`	Design consideration, not a bug — current string-based approach is simpler and sufficient
`utils.ts:105,137`	Type assertion `as Reaction['content']` bypasses runtime validation	Low severity — GitHub's reaction types are stable; trade-off vs parsing overhead not warranted
`index.ts:1052`	404 error message could include more helpful guidance	Merged with 403 handling suggestion; single error handling improvement covers both

Reviewers (8)

Reviewer	Returned	Main Findings	Consider	Inline Comments	Discarded
`pr-review-standards`	3	0	0	3	0
`pr-review-product`	5	0	1	2	2
`pr-review-consistency`	6	0	0	3	1
`pr-review-breaking-changes`	2	0	0	2	0
`pr-review-docs`	1	1	0	0	0
`pr-review-tests`	5	1	0	0	0
`pr-review-types`	3	0	0	0	2
`pr-review-errors`	6	0	0	4	0
Total	31	2	1	14	5

Note: Multiple reviewers flagged overlapping issues (API method name, null safety, breaking change) — findings were deduplicated and consolidated.

claude · 2026-02-18T19:04:32Z

+    markdown += `comments: ${JSON.stringify(issueComments)}\n`;
+    markdown += `Review summaries: ${JSON.stringify(reviewSummaries)}\n`;
+    markdown += `Inline review comments: ${JSON.stringify(reviewComments)}\n`;


🔴 CRITICAL: Breaking change to generatePrMarkdown output format

Issue: The comments section output changed from human-readable markdown to raw JSON.stringify() blobs. This breaks existing consumers of get-pull-request-details.

Why:

Before: Formatted markdown that LLMs could easily parse:
[APPROVED] @reviewer (1/15/2026) LGTM! @commenter (1/15/2026) Fixed as requested src/file.ts: @reviewer line 42 (1/15/2026) Consider using const here

After: Raw JSON strings:
comments: [{"id":123,"body":"Fixed as requested",...}] Review summaries: [{"id":1,"body":"LGTM!",...}]

This significantly degrades usability for LLM agents and breaks any downstream parsing.

Fix: Restore the previous human-readable format. If reactions need to be included, append them inline per comment (e.g., Reactions: +1 (2), heart (1)) rather than switching to JSON.

Refs:

Existing test assertions expecting human-readable format

claude

PR Review Summary

(10) Total Issues | Risk: High

✅ Issues Resolved in This Update

The author addressed 3 critical issues from the prior review:

✅ utils.ts:104 — Fixed null safety: reaction.user?.login ?? '[deleted]'
✅ utils.ts:136 — Fixed null safety: same pattern applied
✅ utils.ts:1017 — Fixed API method name: deleteForPullRequestReviewComment

These fixes are correct and properly implemented.

🕐 Pending Recommendations (10)

The following issues from the prior review remain unresolved:

Critical (2):

🔴 schemas.ts:26-30 Missing id field in ReactionSchema makes remove-comment-reaction unusable — users can't get reaction IDs to remove them
🔴 utils.ts:601-603 Breaking change to generatePrMarkdown output format (human-readable markdown → JSON blobs)

Major (6):

🟠 index.ts:1044-1066 Missing 403 error handling for add-comment-reaction
🟠 index.ts:1135 Missing 403 error handling for remove-comment-reaction
🟠 utils.ts:452-456 Reactions fetch not wrapped in try-catch — failures crash entire operation
🟠 utils.ts:486-490 Same try-catch issue for review comment reactions
🟠 Prior review Missing unit tests for new reaction functions
🟠 Prior review Missing documentation for new MCP tools

Minor (1):

🟡 index.ts:1006 Missing .describe() on reaction parameter

Versioning (1):

🟠 .changeset:2 Changeset should be minor (breaking change), not patch

🚫 REQUEST CHANGES

Summary: Good progress — the 3 fixes in this update are correct. However, 2 critical issues remain unresolved:

ReactionSchema missing id field — Users cannot remove reactions because they can't obtain reaction IDs from get-pull-request-details
generatePrMarkdown breaking change — Output switched from human-readable markdown to JSON, breaking existing consumers

Please address these critical issues. The 403 error handling and try-catch improvements are also important for production reliability but are lower priority.

Reviewers (0)

Reviewer	Returned	Main Findings	Consider	While You're Here	Inline Comments	Pending Recs	Discarded
N/A — delta review	—	—	—	—	—	—	—

Note: This was a delta-scoped re-review. The 3-line change was verified directly without dispatching subagent reviewers.

claude

PR Review Summary

(8) Total Issues | Risk: High

✅ Issues Resolved in This Update

Good progress! The following issues from prior reviews have been addressed:

✅ schemas.ts:27 — Added id field to ReactionSchema
✅ index.ts:1005-1007 — Added .describe() to reaction parameter
✅ utils.ts:457-465 — Added try-catch for issue comment reactions fetch
✅ utils.ts:499-507 — Added try-catch for review comment reactions fetch
✅ index.ts:1073-1083 — Added 403 error handling for add-comment-reaction
✅ .changeset — Updated to minor version (though format is malformed)
✅ Unit tests added for all 6 new reaction utility functions
✅ New list-comment-reactions tool added — enables users to discover reaction IDs

🔴❗ Critical (1) ❗🔴

🔴 1) utils.ts:1035 + utils.test.ts:915,922,934 Regression: Invalid API method name

Issue: Commit 38b39b22b ("address feedback") changed the API method FROM deleteForPullRequestReviewComment TO deleteForPullRequestComment. This is the opposite of what the prior review suggested. The method deleteForPullRequestComment does not exist in Octokit.

Why: This will cause runtime errors when users try to remove reactions from PR review comments. The tests pass because they mock the same invalid method name — providing false confidence.

Fix: Revert to deleteForPullRequestReviewComment in both utils.ts and the test file (see inline comments with 1-click suggestions).

Refs:

Inline Comments:

🔴 Critical: utils.ts:1035 Invalid API method name (regression)
🔴 Critical: utils.test.ts:915 Test mocks invalid method
🔴 Critical: utils.test.ts:922 Test assertion uses invalid method
🔴 Critical: utils.test.ts:934 Test mocks invalid method (error case)

🟠⚠️ Major (1) 🟠⚠️

Inline Comments:

🟠 Major: .changeset/legal-silver-grouse.md:1-5 Malformed frontmatter (4 delimiters instead of 2)

🕐 Pending Recommendations (4)

The following issues from prior reviews remain unresolved:

🔴 utils.ts:619-621 Breaking change: generatePrMarkdown outputs JSON blobs instead of human-readable markdown — still unaddressed
🟠 index.ts:1150-1164 Missing 403 error handling for remove-comment-reaction (only 404 is handled)
🟠 Prior review Missing documentation for new MCP tools
💭 Prior review comment_type enum naming could be more user-friendly

🚫 REQUEST CHANGES

Summary: Good progress on addressing prior feedback — 8 issues were fixed! However, a critical regression was introduced: the deletePullRequestReviewCommentReaction function now calls an invalid Octokit method (deleteForPullRequestComment instead of deleteForPullRequestReviewComment). This will cause runtime failures.

Blocking issues:

API method name regression — 1-click fixes provided in inline comments
Malformed changeset — 1-click fix provided

Still pending from prior reviews:

generatePrMarkdown breaking change (JSON output) — this is the most significant remaining issue
Missing 403 handling for remove-comment-reaction

Discarded (0)

No findings were discarded in this delta review.

Reviewers (0)

Reviewer	Returned	Main Findings	Consider	While You're Here	Inline Comments	Pending Recs	Discarded
N/A — delta review	—	—	—	—	—	—	—

Note: This was a delta-scoped re-review analyzing commits 38b39b22b and 1ac22e04c. No subagent reviewers were dispatched — the delta was analyzed directly by the orchestrator.

claude · 2026-02-18T19:39:33Z

+      const mockOctokit = {
+        rest: {
+          reactions: {
+            deleteForPullRequestComment: vi.fn().mockResolvedValue({}),


🔴 CRITICAL: Test mocks invalid API method name

Issue: This test mocks deleteForPullRequestComment, but the correct Octokit method is deleteForPullRequestReviewComment. The test passes because it's mocking the same invalid method the implementation uses — but both are wrong.

Why: This test provides false confidence. It will pass even though the actual API call at runtime will fail because deleteForPullRequestComment doesn't exist.

Fix: Update to mock the correct method:

Suggested change

deleteForPullRequestComment: vi.fn().mockResolvedValue({}),

deleteForPullRequestReviewComment: vi.fn().mockResolvedValue({}),

Refs:

Implementation using same wrong name

claude · 2026-02-18T19:39:39Z

+
+      await deletePullRequestReviewCommentReaction(mockOctokit, 'owner', 'repo', 55, 202);
+
+      expect(mockOctokit.rest.reactions.deleteForPullRequestComment).toHaveBeenCalledWith({


🔴 CRITICAL: Same issue — update to deleteForPullRequestReviewComment

Suggested change

expect(mockOctokit.rest.reactions.deleteForPullRequestComment).toHaveBeenCalledWith({

expect(mockOctokit.rest.reactions.deleteForPullRequestReviewComment).toHaveBeenCalledWith({

claude · 2026-02-18T19:39:44Z

+      const mockOctokit = {
+        rest: {
+          reactions: {
+            deleteForPullRequestComment: vi.fn().mockRejectedValue(new Error('Not found')),


🔴 CRITICAL: Same issue — update to deleteForPullRequestReviewComment

Suggested change

deleteForPullRequestComment: vi.fn().mockRejectedValue(new Error('Not found')),

deleteForPullRequestReviewComment: vi.fn().mockRejectedValue(new Error('Not found')),

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

miles-kt-inkeep · 2026-02-18T19:51:15Z

test

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

vercel Bot deployed to Preview – agents-api February 18, 2026 19:00 View deployment

vercel Bot deployed to Preview – agents-docs February 18, 2026 19:00 View deployment

vercel Bot deployed to Preview – agents-manage-ui February 18, 2026 19:01 View deployment

claude Bot reviewed Feb 18, 2026

View reviewed changes

github-actions Bot deleted a comment from claude Bot Feb 18, 2026

vercel Bot temporarily deployed to Preview – agents-docs February 18, 2026 19:25 Inactive

github-actions Bot deleted a comment from claude Bot Feb 18, 2026

vercel Bot deployed to Preview – agents-api February 18, 2026 19:27 View deployment

claude Bot reviewed Feb 18, 2026

View reviewed changes

github-actions Bot deleted a comment from claude Bot Feb 18, 2026

vercel Bot deployed to Preview – agents-manage-ui February 18, 2026 19:29 View deployment

vercel Bot temporarily deployed to Preview – agents-docs February 18, 2026 19:35 Inactive

vercel Bot temporarily deployed to Preview – agents-docs February 18, 2026 19:36 Inactive

vercel Bot deployed to Preview – agents-api February 18, 2026 19:38 View deployment

vercel Bot deployed to Preview – agents-manage-ui February 18, 2026 19:40 View deployment

claude Bot reviewed Feb 18, 2026

View reviewed changes

github-actions Bot deleted a comment from claude Bot Feb 18, 2026

miles-kt-inkeep and others added 8 commits February 18, 2026 14:50

Add reaction tooling to github mcp

730520e

Update packages/agents-work-apps/src/github/mcp/utils.ts

60a09cb

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

Update packages/agents-work-apps/src/github/mcp/utils.ts

0818b81

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

Update packages/agents-work-apps/src/github/mcp/utils.ts

9676703

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

address feedback

c8449b6

Apply suggestions from code review

729a09e

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

style: auto-format with biome

dca96a1

update comment formatting

9124e0b

vercel Bot deployed to Preview – agents-api February 18, 2026 19:50 View deployment

miles-kt-inkeep force-pushed the feat/github-mcp-emoji-support branch from be9034f to 9124e0b Compare February 18, 2026 19:50

github-actions Bot deleted a comment from claude Bot Feb 18, 2026

vercel Bot deployed to Preview – agents-api February 18, 2026 19:52 View deployment

github-actions Bot deleted a comment from claude Bot Feb 18, 2026

vercel Bot deployed to Preview – agents-manage-ui February 18, 2026 19:53 View deployment

vercel Bot deployed to Preview – agents-docs February 18, 2026 19:54 View deployment

Update .changeset/legal-silver-grouse.md

dd5f88a

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

vercel Bot deployed to Preview – agents-api February 18, 2026 20:42 View deployment

vercel Bot deployed to Preview – agents-docs February 18, 2026 20:43 View deployment

vercel Bot had a problem deploying to Preview – agents-manage-ui February 18, 2026 20:43 Failure

This comment was marked as resolved.

Sign in to view

udpate tests

588a1dd

vercel Bot temporarily deployed to Preview – agents-docs February 18, 2026 20:49 Inactive

github-actions Bot deleted a comment from claude Bot Feb 18, 2026

vercel Bot deployed to Preview – agents-api February 18, 2026 20:51 View deployment

vercel Bot deployed to Preview – agents-manage-ui February 18, 2026 20:52 View deployment

github-actions Bot deleted a comment from claude Bot Feb 18, 2026

miles-kt-inkeep merged commit 5bd9461 into main Feb 18, 2026
9 checks passed

miles-kt-inkeep deleted the feat/github-mcp-emoji-support branch February 18, 2026 21:00

claude Bot mentioned this pull request Feb 18, 2026

improve routes summary #2011

Closed

	deleteForPullRequestComment: vi.fn().mockResolvedValue({}),
	deleteForPullRequestReviewComment: vi.fn().mockResolvedValue({}),


		await deletePullRequestReviewCommentReaction(mockOctokit, 'owner', 'repo', 55, 202);

		expect(mockOctokit.rest.reactions.deleteForPullRequestComment).toHaveBeenCalledWith({

Conversation

miles-kt-inkeep commented Feb 18, 2026

Uh oh!

vercel Bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

PR Review Summary

🔴❗ Critical (5) ❗🔴

🟠⚠️ Major (5) 🟠⚠️

🟡 Minor (1) 🟡

💭 Consider (1) 💭

🚫 REQUEST CHANGES

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude Bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

PR Review Summary

✅ Issues Resolved in This Update

🕐 Pending Recommendations (10)

🚫 REQUEST CHANGES

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

PR Review Summary

✅ Issues Resolved in This Update

🔴❗ Critical (1) ❗🔴

🟠⚠️ Major (1) 🟠⚠️

🕐 Pending Recommendations (4)

🚫 REQUEST CHANGES

Uh oh!

Uh oh!

claude Bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miles-kt-inkeep commented Feb 18, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Feb 18, 2026 •

edited

Loading

changeset-bot Bot commented Feb 18, 2026 •

edited

Loading