update snapshot#2488
Conversation
🦋 Changeset detectedLatest commit: ab75a87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates the OpenAPI snapshot to reflect recent schema changes in work-app channel/settings endpoints.
|
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
This PR is a mechanical snapshot update capturing schema changes already merged to main. The OpenAPI snapshot reflects the following changes:
Changes Observed
-
Field removals from request schemas:
agentNameandprojectNameremoved fromWorkAppSlackAgentConfigRequestSchema(these are response-only fields that were incorrectly included in request schemas previously) -
Added validation constraints:
maxLength: 256added toagentIdandprojectIdstring fields (derives from DB schema constraints) -
New 400 error responses: Added
"Agent not found"error response to:PUT /{teamId}/settings(update workspace settings)PUT /{teamId}/channels/{channelId}/settings(set channel default agent)
-
Simplified error schemas: Removed redundant
{ success: boolean }schema from500error responses — the body shouldn't be relied upon for error responses anyway
Verification
- Changes are consistent with the source schemas in
packages/agents-core/src/validation/schemas.ts(lines 3070-3084) - Route implementations in
packages/agents-work-apps/src/slack/routes/workspaces.tsconfirm the 400 responses are returned when agent lookup fails (lines 348-355, 869-876) - The changeset correctly targets
@inkeep/agents-apiwith a patch bump
Note
The PR description states "update snapshot" but doesn't specify what source changes prompted the snapshot regeneration. For traceability, consider adding a brief note about the originating PR or changes.
✅ APPROVE
Summary: Clean snapshot update reflecting prior schema refinements. No issues found — the changes correctly capture validation constraints and error response improvements that were already merged to the source code.
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
orchestrator |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
Note: Sub-reviewers not dispatched — this is a pure snapshot update with no source code changes.
There was a problem hiding this comment.
Snapshot is consistent with the current source code — all 12 snapshot tests pass. The OpenAPI diff correctly reflects the upstream schema changes: maxLength: 256 on agentId/projectId, removal of agentName/projectName from request schemas, new 400 responses, and simplified 500 response bodies.
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
This is a delta re-review scoped to changes since the last automated review. The delta consists of a merge commit bringing PR #2487's changes into this snapshot update branch.
Delta Changes Reviewed
The merge introduced the "pass cron timezone to agent in scheduled trigger execution" feature:
| File | Change |
|---|---|
TriggerService.ts |
Added buildScheduledTriggerHeaders() helper that returns x-inkeep-client-timezone and x-inkeep-client-timestamp headers |
TriggerService.ts |
Added forwardedHeaders parameter to executeAgentAsync() |
scheduledTriggers.ts |
Wired forwardedHeaders in 2 test/manual execution paths |
scheduledTriggerRunner.ts |
Passed cronTimezone from trigger config to step execution |
scheduledTriggerSteps.ts |
Added cronTimezone param and called buildScheduledTriggerHeaders() |
Analysis
-
Implementation is clean: The
buildScheduledTriggerHeaders()helper correctly handlesnull/undefinedtimezone by falling back to'UTC'. -
Consistent usage: All 3 call sites in the delta use the same pattern (
buildScheduledTriggerHeaders(trigger.cronTimezone)orbuildScheduledTriggerHeaders(cronTimezone)). -
Headers flow correctly: The
forwardedHeadersare spread into MCP server headers (line 300 ofexecutionHandler.ts) and stored in message metadata (line 310), enabling downstream consumers to access the scheduled trigger's timezone context. -
No breaking changes: This is additive — existing triggers without
cronTimezonewill default to'UTC'.
Note
This delta code was already reviewed and merged to main via PR #2487. The current PR's synchronize event reflects that merge into the snapshot update branch.
✅ APPROVE
Summary: Clean delta — the cron timezone feature is correctly plumbed through the scheduled trigger execution chain. No issues found. Ship it! 🚀
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
orchestrator |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
Note: Direct orchestrator review — delta is already-merged code from PR #2487 with straightforward parameter plumbing.
|
Claude encountered an error —— View job PR Review in Progress
Context Analysis:
Decision: Fast-tracking to review submission (no sub-reviewers needed for a changeset-only change). |
No description provided.