Skip to content

update snapshot#2488

Closed
omar-inkeep wants to merge 3 commits intomainfrom
update-snapshot
Closed

update snapshot#2488
omar-inkeep wants to merge 3 commits intomainfrom
update-snapshot

Conversation

@omar-inkeep
Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 3, 2026

🦋 Changeset detected

Latest commit: ab75a87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@inkeep/agents-api Patch
@inkeep/agents-manage-ui Patch
@inkeep/agents-cli Patch
@inkeep/agents-core Patch
@inkeep/agents-email Patch
@inkeep/agents-mcp Patch
@inkeep/agents-sdk Patch
@inkeep/agents-work-apps Patch
@inkeep/ai-sdk-provider Patch
@inkeep/create-agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agents-api Ready Ready Preview, Comment Mar 3, 2026 4:25am
agents-docs Ready Ready Preview, Comment Mar 3, 2026 4:25am
agents-manage-ui Ready Ready Preview, Comment Mar 3, 2026 4:25am

Request Review

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Mar 3, 2026

Updates the OpenAPI snapshot to reflect recent schema changes in work-app channel/settings endpoints.

  • .changeset/smooth-icons-grow.md — adds patch changeset for @inkeep/agents-api
  • agents-api/__snapshots__/openapi.json — removes agentName / projectName fields from defaultAgent and agentConfig objects across multiple channel settings endpoints, adds maxLength: 256 constraints to agentId and projectId, adds a 400 ("Agent not found") response to channel default-agent and settings routes, and simplifies the 500 response schema on the update-settings endpoint

Pullfrog  | View workflow run | Using Claude Code | Triggered by Pullfrogpullfrog.com𝕏

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

This PR is a mechanical snapshot update capturing schema changes already merged to main. The OpenAPI snapshot reflects the following changes:

Changes Observed

  1. Field removals from request schemas: agentName and projectName removed from WorkAppSlackAgentConfigRequestSchema (these are response-only fields that were incorrectly included in request schemas previously)

  2. Added validation constraints: maxLength: 256 added to agentId and projectId string fields (derives from DB schema constraints)

  3. New 400 error responses: Added "Agent not found" error response to:

    • PUT /{teamId}/settings (update workspace settings)
    • PUT /{teamId}/channels/{channelId}/settings (set channel default agent)
  4. Simplified error schemas: Removed redundant { success: boolean } schema from 500 error responses — the body shouldn't be relied upon for error responses anyway

Verification

  • Changes are consistent with the source schemas in packages/agents-core/src/validation/schemas.ts (lines 3070-3084)
  • Route implementations in packages/agents-work-apps/src/slack/routes/workspaces.ts confirm the 400 responses are returned when agent lookup fails (lines 348-355, 869-876)
  • The changeset correctly targets @inkeep/agents-api with a patch bump

Note

The PR description states "update snapshot" but doesn't specify what source changes prompted the snapshot regeneration. For traceability, consider adding a brief note about the originating PR or changes.


✅ APPROVE

Summary: Clean snapshot update reflecting prior schema refinements. No issues found — the changes correctly capture validation constraints and error response improvements that were already merged to the source code.

Reviewers (1)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
orchestrator 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: Sub-reviewers not dispatched — this is a pure snapshot update with no source code changes.

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshot is consistent with the current source code — all 12 snapshot tests pass. The OpenAPI diff correctly reflects the upstream schema changes: maxLength: 256 on agentId/projectId, removal of agentName/projectName from request schemas, new 400 responses, and simplified 500 response bodies.

Pullfrog  | View workflow runpullfrog.com𝕏

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

This is a delta re-review scoped to changes since the last automated review. The delta consists of a merge commit bringing PR #2487's changes into this snapshot update branch.

Delta Changes Reviewed

The merge introduced the "pass cron timezone to agent in scheduled trigger execution" feature:

File Change
TriggerService.ts Added buildScheduledTriggerHeaders() helper that returns x-inkeep-client-timezone and x-inkeep-client-timestamp headers
TriggerService.ts Added forwardedHeaders parameter to executeAgentAsync()
scheduledTriggers.ts Wired forwardedHeaders in 2 test/manual execution paths
scheduledTriggerRunner.ts Passed cronTimezone from trigger config to step execution
scheduledTriggerSteps.ts Added cronTimezone param and called buildScheduledTriggerHeaders()

Analysis

  1. Implementation is clean: The buildScheduledTriggerHeaders() helper correctly handles null/undefined timezone by falling back to 'UTC'.

  2. Consistent usage: All 3 call sites in the delta use the same pattern (buildScheduledTriggerHeaders(trigger.cronTimezone) or buildScheduledTriggerHeaders(cronTimezone)).

  3. Headers flow correctly: The forwardedHeaders are spread into MCP server headers (line 300 of executionHandler.ts) and stored in message metadata (line 310), enabling downstream consumers to access the scheduled trigger's timezone context.

  4. No breaking changes: This is additive — existing triggers without cronTimezone will default to 'UTC'.

Note

This delta code was already reviewed and merged to main via PR #2487. The current PR's synchronize event reflects that merge into the snapshot update branch.


✅ APPROVE

Summary: Clean delta — the cron timezone feature is correctly plumbed through the scheduled trigger execution chain. No issues found. Ship it! 🚀

Reviewers (1)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
orchestrator 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: Direct orchestrator review — delta is already-merged code from PR #2487 with straightforward parameter plumbing.

@github-actions github-actions Bot deleted a comment from claude Bot Mar 3, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Mar 3, 2026

Claude encountered an error —— View job


PR Review in Progress

  • Phase 1: Analyze Context
  • Phase 1.5: Generate PR TLDR
  • Phase 2: Select Reviewers
  • Phase 3: Dispatch Reviewers
  • Phase 4: Judge & Filter
  • Phase 5: Inline Comments via Pending Review
  • Phase 6: Submit Review with Summary

Context Analysis:

  • PR originally contained openapi.json snapshot + changeset
  • After merge commits, openapi.json changes are now in main (via PR Version Packages #2481)
  • Current PR diff: Only .changeset/smooth-icons-grow.md (+5 lines)
  • This is a trivial changeset-only PR

Decision: Fast-tracking to review submission (no sub-reviewers needed for a changeset-only change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants