Root override is correct — both old dompurify versions (3.2.7, 3.3.1) are fully replaced with 3.3.2, lockfile is clean, and Node compatibility is fine (repo requires >=22.18.0, [email protected] requires >=20). One gap: create-agents-template/ has its own overrides and lockfile that still resolve the vulnerable version.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ pullfrog.com ｜ 𝕏}

PR Review Summary

(2) Total Issues | Risk: Medium

🟠⚠️ Major (1) 🟠⚠️

🟠 1) create-agents-template/package.json Missing dompurify override in self-hosted template

files:

• create-agents-template/package.json
• create-agents-template/pnpm-lock.yaml

Issue: The root package.json adds the dompurify >= 3.3.2 override to fix CVE-2026-0540, but create-agents-template/package.json has its own pnpm.overrides section that is not updated. The template's lockfile still shows monaco-editor depending on [email protected] (line 22422), which is the vulnerable version.

Why: Self-hosted customers who scaffold new projects using @inkeep/create-agents will deploy with the vulnerable dompurify version. This contradicts the security intent of the PR. Previous security fixes in this branch (e.g., @modelcontextprotocol/sdk in fa64456, @hono/node-server in 02bcd0e) correctly updated both the root AND the template.

Fix: Add "dompurify": ">=3.3.2" to create-agents-template/package.json under pnpm.overrides:

"pnpm": {
  "overrides": {
    "@modelcontextprotocol/sdk": ">=1.26.0",
    "@hono/node-server": ">=1.19.10",
    "dompurify": ">=3.3.2"
  }
}

Then run pnpm install in that directory to regenerate the lockfile. Verify that [email protected] is replaced by [email protected].

Refs:

• create-agents-template/package.json:52-56 — existing pnpm.overrides section
• create-agents-template/pnpm-lock.yaml (vulnerable version) — monaco-editor still using [email protected]

🟡 Minor (1) 🟡

🟡 1) .changeset/* Consider adding changeset for security fix visibility

Issue: This PR fixes a security vulnerability but does not include a changeset. The prior security fixes in this branch (b9b1a75, 980fab5, fa64456, 02bcd0e) included changesets.

Why: Security fixes should be documented in release notes so downstream consumers of @inkeep/agents-manage-ui (which uses monaco-editor → dompurify) know to upgrade.

Fix: Optional but recommended — create a changeset:

pnpm bump patch --pkg agents-manage-ui "Fix XSS bypass vulnerability in dompurify transitive dependency (CVE-2026-0540)"

Refs: Changeset bot comment above — already flagged missing changeset

💭 Consider (1) 💭

Inline Comments:

• 💭 Consider: package.json:130 Open-ended version range (>=3.3.2) — consistent with existing patterns

Summary: The root monorepo fix is correct — dompurify 3.2.7/3.3.1 are consolidated to 3.3.2 and the override is working. However, the self-hosted template is missing the override and will deploy vulnerable [email protected] to customers who scaffold from it. Please apply the same fix to create-agents-template/package.json to complete the security remediation.

PR Review Summary

(1) Total Issues | Risk: Medium

🕐 Pending Recommendations (1)

• 🟠 create-agents-template/package.json:52-56 Missing security overrides in self-hosted template — vulnerable [email protected] still resolves via monaco-editor

Summary: The root monorepo fix is correct — all 8 security overrides are properly applied and the lockfile shows safe versions. However, the prior review finding remains unresolved: create-agents-template/package.json has its own pnpm.overrides section that was not updated, leaving self-hosted customers vulnerable to CVE-2026-0540 (and potentially other CVEs addressed in this PR).

To resolve: Add all new overrides to create-agents-template/package.json:

"pnpm": {
  "overrides": {
    "@modelcontextprotocol/sdk": ">=1.26.0",
    "@hono/node-server": ">=1.19.10",
    "dompurify": ">=3.3.2",
    "fast-xml-parser": ">=5.3.8",
    "serialize-javascript": ">=7.0.3",
    "svgo": ">=3.3.3",
    "minimatch": ">=5.1.8",
    "lodash": ">=4.17.23",
    "lodash-es": ">=4.17.23",
    "express-rate-limit": ">=8.2.2"
  }
}

Then run pnpm install in create-agents-template/ to regenerate the lockfile.

PR Review Summary

(0) Total Issues | Risk: Low

✅ Prior Feedback Addressed

The delta commit (78d5cb820) correctly addresses the previously identified issue:

Verification

Template overrides now match root monorepo:

"pnpm": {
  "overrides": {
    "@modelcontextprotocol/sdk": ">=1.26.0",
    "@hono/node-server": ">=1.19.10",
    "dompurify": ">=3.3.2",
    "fast-xml-parser": ">=5.3.8",
    "serialize-javascript": ">=7.0.3",
    "svgo": ">=3.3.3",
    "minimatch": ">=5.1.8",
    "lodash": ">=4.17.23",
    "lodash-es": ">=4.17.23",
    "express-rate-limit": ">=8.2.2"
  }
}

Lockfile validation:

• ✅ [email protected] entry removed
• ✅ [email protected] now used by monaco-editor
• ✅ [email protected] no longer used (marked optional, replaced by 10.2.4)

Summary: The delta fully addresses the prior review feedback. Both the root monorepo and the self-hosted template now have consistent security overrides, ensuring customers deploying via @inkeep/create-agents will receive patched dependency versions. All vulnerable transitive dependencies are properly pinned to safe versions. Ship it! 🚀

PR Review Summary

(0) Total Issues | Risk: Low

✅ Delta Review — Clean Sync Commit

This is a delta review scoped to commit 489fc1875 fix(security): sync overrides between root and create-agents-template. The prior review already APPROVED the core security fix.

Delta changes verified:

Verification:

• ✅ Root and template now have identical 11 security overrides
• ✅ Template lockfile correctly applies all overrides
• ✅ No vulnerable transitive dependencies remain
• ✅ Lockfile pruned ~40 lines of dead packages

Summary: The delta correctly synchronizes pnpm overrides between the root monorepo and create-agents-template. Both now have identical security overrides, ensuring consistent vulnerability remediation for both monorepo development and self-hosted deployments via @inkeep/create-agents. Clean sync — ship it! 🚀