Skip to content

Update deploy-signoz-nango.mdx with SIGNOZ_TOKENIZER_JWT_SECRET#2831

Merged
robert-inkeep merged 1 commit intomainfrom
robert-inkeep-patch-2
Mar 25, 2026
Merged

Update deploy-signoz-nango.mdx with SIGNOZ_TOKENIZER_JWT_SECRET#2831
robert-inkeep merged 1 commit intomainfrom
robert-inkeep-patch-2

Conversation

@robert-inkeep
Copy link
Copy Markdown
Collaborator

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agents-api Ready Ready Preview, Comment Mar 27, 2026 10:41pm
agents-docs Ready Ready Preview, Comment Mar 27, 2026 10:41pm
agents-manage-ui Ready Ready Preview, Comment Mar 27, 2026 10:41pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2026

⚠️ No Changeset found

Latest commit: fc56d23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Mar 25, 2026

TL;DR — Adds SIGNOZ_TOKENIZER_JWT_SECRET to the self-hosting setup snippet so it is auto-generated alongside the existing Nango secrets during docker-compose environment bootstrapping.

Key changes

  • Add SIGNOZ_TOKENIZER_JWT_SECRET to deploy setup snippet — generates the secret with openssl rand, substitutes it into .env via sed, and lists it in the production variable overview.

Summary | 1 file | 1 commit | base: mainrobert-inkeep-patch-2

Before: The .env autogeneration script only created and substituted NANGO_ENCRYPTION_KEY and NANGO_DASHBOARD_PASSWORD; SIGNOZ_TOKENIZER_JWT_SECRET had to be set manually.
After: SIGNOZ_TOKENIZER_JWT_SECRET is auto-generated (openssl rand -base64 32), substituted into .env, and documented in the production variables list.

deploy-signoz-nango.mdx

Pullfrog  | View workflow run | Triggered by Pullfrogpullfrog.com𝕏

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal docs change. The new SIGNOZ_TOKENIZER_JWT_SECRET follows the exact same generate→substitute→document pattern as the existing Nango secrets. No issues found.

Pullfrog  | View workflow runpullfrog.com𝕏

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

This PR adds documentation for a new SigNoz environment variable SIGNOZ_TOKENIZER_JWT_SECRET to the self-hosting deployment guide. The change is straightforward and correctly follows existing patterns.

✅ What's Good

  1. Consistent Pattern: The new variable follows the same generation pattern as existing secrets (openssl rand -base64 32)
  2. Complete Change: Updates all three required places:
    • Variable generation (line 12)
    • sed replacement (line 17)
    • Echo confirmation message (line 20)
    • "Important env vars" reference section (line 28)
  3. Proper Snippet Reuse: This snippet is included in 4 deployment guides (AWS EC2, Azure VM, GCP Compute Engine, Hetzner), so all are automatically updated

💭 Consider (1)

💭 1) deploy-signoz-nango.mdx Add brief context for what this secret is used for

Issue: Unlike NANGO_ENCRYPTION_KEY which has an explanatory note ("Once you create this, it cannot be edited"), SIGNOZ_TOKENIZER_JWT_SECRET is added without any context on its purpose.

Why: Self-hosting users benefit from understanding what each secret configures, especially when troubleshooting. It's unclear whether this is a SigNoz core requirement or specific to the Inkeep integration.

Fix: Consider adding a brief note after line 28, e.g.: # Required for SigNoz query-service authentication (adjust based on actual purpose).

Refs: SigNoz environment docs may have details on this variable's purpose.


✅ APPROVE

Summary: Clean documentation update that correctly adds SIGNOZ_TOKENIZER_JWT_SECRET to the self-hosting setup scripts. The change follows existing patterns and updates all necessary locations. The only suggestion is optionally adding context about what this secret is used for — but this is a minor polish item that shouldn't block merge.

Discarded (0)
Location Issue Reason Discarded
None
Reviewers (0)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
orchestrator-direct 1 0 1 0 0 0 0
Total 1 0 1 0 0 0 0

Note: Small docs-only PR reviewed directly by orchestrator without sub-agent dispatch (appropriate for 1-file, +4/-1 documentation change).

@github-actions github-actions Bot deleted a comment from claude Bot Mar 25, 2026
@robert-inkeep robert-inkeep enabled auto-merge March 25, 2026 13:24
@robert-inkeep robert-inkeep added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit 0ec1c5c Mar 25, 2026
19 of 20 checks passed
@robert-inkeep robert-inkeep deleted the robert-inkeep-patch-2 branch March 25, 2026 13:38
@github-actions
Copy link
Copy Markdown
Contributor

🔎💬 Inkeep AI search and chat service is syncing content for source 'Inkeep Agent Framework Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant