Making agent timeout more noticeable in trace conversation view by shagun-singh-inkeep · Pull Request #2908 · inkeep/agents

shagun-singh-inkeep · 2026-03-30T20:07:59Z

No description provided.

changeset-bot · 2026-03-30T20:08:04Z

🦋 Changeset detected

Latest commit: d18a932

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@inkeep/agents-manage-ui	Patch
@inkeep/agents-api	Patch
@inkeep/agents-cli	Patch
@inkeep/agents-core	Patch
@inkeep/agents-email	Patch
@inkeep/agents-mcp	Patch
@inkeep/agents-sdk	Patch
@inkeep/agents-work-apps	Patch
@inkeep/ai-sdk-provider	Patch
@inkeep/create-agents	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-03-30T20:08:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agents-api	Building	Preview, Comment	Mar 30, 2026 8:08pm
agents-manage-ui	Building	Preview, Comment	Mar 30, 2026 8:08pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
agents-docs	Skipped		Mar 30, 2026 8:08pm

pullfrog · 2026-03-30T20:09:16Z

TL;DR — Surfaces stream timeout events as a prominent red alert banner in the trace conversation detail view, so timeouts are immediately visible instead of buried in activity data.

Key changes

Add stream timeout alert to Alerts card — when a conversation's activities include a STREAM_LIFETIME_EXCEEDED event, a red banner with a Timer icon and the exceeded duration is displayed at the top of the Alerts card; the "0 warnings" empty state is hidden when a timeout is present.

_{Summary ｜ 2 files ｜ 2 commits ｜ base: main ← TI-31}

Before: Stream timeouts were recorded as activity events but had no dedicated visual indicator in the Alerts card — a conversation that timed out could still show "0 warnings or errors."
After: A red Stream timed out banner (with the exceeded limit in seconds) appears at the top of the Alerts card whenever a STREAM_LIFETIME_EXCEEDED activity exists. The "No warnings or errors" empty state is suppressed when a timeout is present.

The component finds the first STREAM_LIFETIME_EXCEEDED activity, renders a styled div with the Timer icon from lucide-react, and conditionally displays the streamMaxLifetimeMs converted to seconds. The CardContent also gains overflow-y-auto for scrollable content when both a timeout banner and error/warning counts are present.

page.tsx · types.ts (via ACTIVITY_TYPES import)

^{｜ View workflow run ｜ Triggered by Pullfrog ｜ Using Claude Opus ｜ 𝕏}

pullfrog

Clean, focused change. The timeout banner integrates well with the existing Alerts card and follows established patterns (dark mode support, existing type constants, consistent icon usage). The overflow-y-auto + flex layout changes are a good defensive addition for the constrained card height. One minor suggestion inline.

^{｜ View workflow run ｜ Using Claude Opus ｜ 𝕏}

pullfrog · 2026-03-30T20:09:34Z

+                        {streamTimeoutActivity.streamMaxLifetimeMs &&
+                          streamTimeoutActivity.streamMaxLifetimeMs > 0 && (


Nit: the truthiness check on line 470 is redundant — > 0 alone already handles undefined, null, and 0 (all produce false). The existing pattern in timeline-item.tsx:569 uses != null && > 0, but even simpler:

streamTimeoutActivity.streamMaxLifetimeMs > 0

Not blocking — current code works correctly.

claude

PR Review Summary

(2) Total Issues | Risk: Low

🟡 Minor (2) 🟡

Inline Comments:

🟡 Minor: page.tsx:464 Missing ARIA role for alert notification
🟡 Minor: page.tsx:465 Decorative Timer icon should be hidden from screen readers

💭 Consider (1) 💭

💭 1) page.tsx:508 Show SigNoz link for timeout-only scenarios

Issue: The "View in SigNoz" button only appears when total > 0, so users won't see it when there's only a stream timeout but no other errors/warnings.

Why: When debugging a timeout issue, access to the SigNoz trace view would be valuable even when there are no additional errors or warnings to investigate.

Fix: Consider extending the condition to also show for timeout scenarios:

{(total > 0 || streamTimeoutActivity) && !isCloudDeployment && (

💡 APPROVE WITH SUGGESTIONS

Summary: This is a clean, focused UI improvement that makes stream timeouts more visible in the trace conversation view. The implementation follows existing patterns in the codebase and includes proper dark mode support. The two accessibility improvements (ARIA role + aria-hidden on icon) are quick 1-click fixes. The SigNoz button consideration is optional UX polish. Nice work! 🎉

Discarded (5)

Location	Issue	Reason Discarded
`page.tsx:453`	Extract IIFE logic into separate component	Pre-existing pattern used throughout the file; out of scope for this PR
`page.tsx:474`	Magic number division by 1000	Low value nitpick; the ms-to-seconds conversion is clear in context
`page.tsx:470`	Sub-second timeout display format	Speculative edge case; timeouts are typically configured in whole seconds
`page.tsx:502`	Ternary chain readability	Valid but minor; the logic is correct and the behavior is intentional
`page.tsx:457`	Activities array undefined handling	Code already handles this correctly via optional chaining

Reviewers (2)

Reviewer	Returned	Consider	Inline Comments	Discarded
`pr-review-frontend`	5	0	2	3
`pr-review-standards`	5	1	0	4
Total	10	1	2	7

claude · 2026-03-30T20:11:09Z

              return (
                <>
+                  {streamTimeoutActivity && (
+                    <div className="flex items-center gap-2 rounded-md border border-red-200 bg-red-50 px-3 py-2 mb-3 dark:border-red-900 dark:bg-red-950/50">


🟡 Minor: Missing ARIA role for alert notification

Issue: The stream timeout alert box lacks proper ARIA attributes to convey its semantic meaning to assistive technologies.

Why: Screen reader users won't be notified that this is an important alert/error message. The visual styling (red colors, warning icon) conveys urgency that is lost without semantic markup.

Fix: (1-click apply)

Suggested change

<div className="flex items-center gap-2 rounded-md border border-red-200 bg-red-50 px-3 py-2 mb-3 dark:border-red-900 dark:bg-red-950/50">

{streamTimeoutActivity && (

<div role="alert" className="flex items-center gap-2 rounded-md border border-red-200 bg-red-50 px-3 py-2 mb-3 dark:border-red-900 dark:bg-red-950/50">

Refs:

WCAG 2.1 Status Messages

MDN ARIA alert role

claude · 2026-03-30T20:11:12Z

                <>
+                  {streamTimeoutActivity && (
+                    <div className="flex items-center gap-2 rounded-md border border-red-200 bg-red-50 px-3 py-2 mb-3 dark:border-red-900 dark:bg-red-950/50">
+                      <Timer className="h-4 w-4 text-red-500 flex-shrink-0" />


🟡 Minor: Decorative icon should be hidden from screen readers

Issue: The Timer icon is decorative (the text already conveys the meaning) but may be announced by screen readers as "timer".

Why: Screen readers might announce the icon before the actual message, creating a confusing experience for users relying on assistive technology.

Fix: (1-click apply)

Suggested change

<Timer className="h-4 w-4 text-red-500 flex-shrink-0" />

<Timer className="h-4 w-4 text-red-500 flex-shrink-0" aria-hidden="true" />

Refs:

W3C Decorative Images Tutorial

inkeep · 2026-03-30T20:50:47Z

No documentation updates needed. This is a UI visual enhancement to the trace conversation view that doesn't introduce new features or change existing workflows.

itoqa · 2026-03-30T21:15:03Z

Ito Test Report ✅

11 test cases ran. 11 passed.

All 11 test cases passed, confirming the Alerts-card timeout feature behaved correctly across baseline, timeout-positive, edge, mobile, and security/resilience scenarios with no production-code defects identified. The most important findings were that timeout rendering is strictly and correctly gated (including exact activity-type matching, first-timeout selection, conditional duration text, zero-state suppression, and preserved warning/error metrics), the SigNoz escalation path and mobile usability remained intact, and no stale-state leakage, unauthenticated data exposure, or XSS execution path was observed.

✅ Passed (11)

Category	Summary	Screenshot
Adversarial	Invalid timeout activity type variants do not trigger the timeout banner due to exact type matching.
Adversarial	Timeout-related XSS payload handling validated as safe with no executable HTML/JS rendering path found.
Adversarial	Rapid back/forward navigation and refresh preserved correct timeout state per conversation with no stale banner leakage.
Adversarial	Unauthenticated deep-link access resolved to login-gated or safe error behavior without conversation data disclosure.
Edge	Duration subtext is correctly suppressed when timeout max lifetime is 0 or missing.
Edge	With timeout present and warning/error counts forced to zero, timeout UI remains visible and zero-state text stays hidden.
Edge	Alerts card consistently uses the first timeout activity; swapping activity order updates the displayed limit accordingly.
Edge	Mobile conversation details remained usable in portrait and landscape with timeout banner visible and Alerts content scrollable.
Happy-path	Baseline conversation renders Alerts without a timeout banner after local environment repair and deterministic payload validation.
Happy-path	Timeout-positive conversation correctly shows the red Stream timed out banner with Exceeded 45s limit while preserving warning/error metrics.
Happy-path	Timeout-positive conversation continues to expose the View in SigNoz escalation path in non-cloud mode.

Commit: d18a932

View Full Run

Tell us how we did: Give Ito Feedback

* Making agent timeout more noticeable in trace conversation view * typed

shagun-singh-inkeep added 2 commits March 30, 2026 16:05

Making agent timeout more noticeable in trace conversation view

156359e

typed

d18a932

pullfrog Bot reviewed Mar 30, 2026

View reviewed changes

vercel Bot deployed to Preview – agents-api March 30, 2026 20:10 View deployment

vercel Bot deployed to Preview – agents-manage-ui March 30, 2026 20:10 View deployment

claude Bot reviewed Mar 30, 2026

View reviewed changes

github-actions Bot deleted a comment from claude Bot Mar 30, 2026

shagun-singh-inkeep added this pull request to the merge queue Mar 30, 2026

Merged via the queue into main with commit 4fa11aa Mar 30, 2026
28 checks passed

shagun-singh-inkeep deleted the TI-31 branch March 30, 2026 20:49

tim-inkeep pushed a commit that referenced this pull request Mar 31, 2026

Making agent timeout more noticeable in trace conversation view (#2908)

370a4f6

* Making agent timeout more noticeable in trace conversation view * typed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Making agent timeout more noticeable in trace conversation view#2908

Making agent timeout more noticeable in trace conversation view#2908
shagun-singh-inkeep merged 2 commits intomainfrom
TI-31

shagun-singh-inkeep commented Mar 30, 2026

Uh oh!

changeset-bot Bot commented Mar 30, 2026

Uh oh!

vercel Bot commented Mar 30, 2026

Uh oh!

pullfrog Bot commented Mar 30, 2026

Uh oh!

pullfrog Bot left a comment

Uh oh!

pullfrog Bot Mar 30, 2026

Uh oh!

claude Bot left a comment

Uh oh!

claude Bot Mar 30, 2026

Uh oh!

claude Bot Mar 30, 2026

Uh oh!

Uh oh!

inkeep Bot commented Mar 30, 2026

Uh oh!

itoqa Bot commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		{streamTimeoutActivity.streamMaxLifetimeMs &&
		streamTimeoutActivity.streamMaxLifetimeMs > 0 && (

	<div className="flex items-center gap-2 rounded-md border border-red-200 bg-red-50 px-3 py-2 mb-3 dark:border-red-900 dark:bg-red-950/50">
	{streamTimeoutActivity && (
	<div role="alert" className="flex items-center gap-2 rounded-md border border-red-200 bg-red-50 px-3 py-2 mb-3 dark:border-red-900 dark:bg-red-950/50">

	<Timer className="h-4 w-4 text-red-500 flex-shrink-0" />
	<Timer className="h-4 w-4 text-red-500 flex-shrink-0" aria-hidden="true" />

Conversation

shagun-singh-inkeep commented Mar 30, 2026

Uh oh!

changeset-bot Bot commented Mar 30, 2026

🦋 Changeset detected

Uh oh!

vercel Bot commented Mar 30, 2026

Uh oh!

pullfrog Bot commented Mar 30, 2026

Key changes

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

pullfrog Bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

PR Review Summary

🟡 Minor (2) 🟡

💭 Consider (1) 💭

💡 APPROVE WITH SUGGESTIONS

Uh oh!

claude Bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

inkeep Bot commented Mar 30, 2026

Uh oh!

itoqa Bot commented Mar 30, 2026

Ito Test Report ✅

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant