Skip to content

fix(ci): configure git remote with App token in release workflow#2901

Merged
amikofalvy merged 1 commit intomainfrom
worktree-fix-release-ci-trigger
Mar 30, 2026
Merged

fix(ci): configure git remote with App token in release workflow#2901
amikofalvy merged 1 commit intomainfrom
worktree-fix-release-ci-trigger

Conversation

@amikofalvy
Copy link
Copy Markdown
Collaborator

Summary

  • The changesets/action in release.yml pushes commits to the changeset-release/main branch using the default GITHUB_TOKEN credential, which GitHub ignores for triggering downstream workflows (infinite loop prevention)
  • This left PR Version Packages #2881 (Version Packages) stuck with required checks (ci, Cypress E2E Tests, Create Agents E2E Tests) permanently at "Waiting for status to be reported"
  • Configures the git remote URL with the inkeep-internal-ci App token before changesets/action runs, same pattern applied to ci.yml and auto-format.yml in fix(ci): use GitHub App token for auto-commits to trigger CI #2871

Test plan

  • Merge this PR, then verify the next changeset-release/main push triggers CI workflows
  • Alternatively, close and re-open PR Version Packages #2881 after merge to retrigger, or re-run the Publish workflow

🤖 Generated with Claude Code

The changesets/action pushes commits using the default GITHUB_TOKEN
credential, which GitHub ignores for triggering downstream workflows.
This left the Version Packages PR (#2881) stuck with required checks
(ci, Cypress E2E, Create Agents E2E) permanently waiting.

Configures the git remote URL with the inkeep-internal-ci App token
before changesets/action runs — same pattern applied to ci.yml and
auto-format.yml in #2871.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agents-api Ready Ready Preview, Comment Mar 30, 2026 7:15pm
agents-docs Ready Ready Preview, Comment Mar 30, 2026 7:15pm
agents-manage-ui Ready Ready Preview, Comment Mar 30, 2026 7:15pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 30, 2026

⚠️ No Changeset found

Latest commit: 90b0985

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@amikofalvy amikofalvy enabled auto-merge March 30, 2026 19:13
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Mar 30, 2026

TL;DR — Configures the git remote in release.yml to use the inkeep-internal-ci GitHub App token before changesets/action runs, so that commits pushed to changeset-release/main actually trigger downstream CI workflows instead of being silently ignored by GitHub's GITHUB_TOKEN loop-prevention.

Key changes

Summary | 1 file | 1 commit | base: mainworktree-fix-release-ci-trigger


Before: changesets/action pushed commits using the default GITHUB_TOKEN, which GitHub silently refuses to use as a trigger for downstream workflows — leaving required checks (ci, Cypress E2E Tests, Create Agents E2E Tests) permanently stuck at "Waiting for status to be reported."
After: A new step runs git remote set-url origin with the App token before changesets/action, so pushed commits are attributed to the inkeep-internal-ci App and correctly trigger all downstream CI.

The fix mirrors the exact pattern from #2871 where ci.yml and auto-format.yml were updated for the same reason. The release.yml workflow was the remaining workflow that still relied on the default credential for its git pushes.

Why does GitHub ignore pushes from GITHUB_TOKEN?

To prevent infinite workflow loops, GitHub will not trigger push or pull_request events when a workflow pushes commits using the built-in GITHUB_TOKEN. Using a GitHub App installation token sidesteps this restriction because the push is attributed to the App identity, not the workflow itself.

.github/workflows/release.yml

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Claude Opus𝕏

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, correct fix. The git remote set-url step is placed exactly where it needs to be — after the App token is generated and before changesets/action pushes commits. This matches the established pattern in ci.yml and auto-format.yml. The token is safely passed via env: (not string-interpolated), and the unconditional execution is appropriate since this workflow only runs on push to main or workflow_dispatch (never fork PRs).

Pullfrog  | View workflow run | Using Claude Opus𝕏

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

This PR adds the git remote set-url configuration step to the release workflow, ensuring commits pushed by changesets/action use the App token and properly trigger downstream CI workflows.

Analysis

Pattern consistency: ✅ The implementation exactly matches the established pattern already used in:

Placement: ✅ Correctly positioned after Generate GitHub App Token step and before changesets/action — the token must be available before it's used.

Security: ✅ Token is passed via environment variable (APP_TOKEN), not hardcoded. Uses the existing inkeep-internal-ci App credentials.

Problem solved: This addresses the root cause of PR #2881's stuck checks — without the App token in the remote URL, GitHub's infinite loop prevention ignores the push for workflow triggering purposes.


✅ APPROVE

Summary: Clean, minimal fix that follows the established pattern from PR #2871. The change is correctly placed, uses secure credential handling, and directly addresses the CI workflow triggering issue.


Reviewers (1)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
orchestrator 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: No sub-reviewers dispatched — this is a minimal CI workflow change following an established pattern.

@github-actions github-actions Bot deleted a comment from claude Bot Mar 30, 2026
@amikofalvy amikofalvy added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 3debd2e Mar 30, 2026
20 checks passed
@amikofalvy amikofalvy deleted the worktree-fix-release-ci-trigger branch March 30, 2026 19:35
tim-inkeep pushed a commit that referenced this pull request Mar 31, 2026
The changesets/action pushes commits using the default GITHUB_TOKEN
credential, which GitHub ignores for triggering downstream workflows.
This left the Version Packages PR (#2881) stuck with required checks
(ci, Cypress E2E, Create Agents E2E) permanently waiting.

Configures the git remote URL with the inkeep-internal-ci App token
before changesets/action runs — same pattern applied to ci.yml and
auto-format.yml in #2871.

Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant