fix(ci): configure git remote with App token in release workflow#2901
fix(ci): configure git remote with App token in release workflow#2901amikofalvy merged 1 commit intomainfrom
Conversation
The changesets/action pushes commits using the default GITHUB_TOKEN credential, which GitHub ignores for triggering downstream workflows. This left the Version Packages PR (#2881) stuck with required checks (ci, Cypress E2E, Create Agents E2E) permanently waiting. Configures the git remote URL with the inkeep-internal-ci App token before changesets/action runs — same pattern applied to ci.yml and auto-format.yml in #2871. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
TL;DR — Configures the git remote in Key changes
Summary | 1 file | 1 commit | base:
The fix mirrors the exact pattern from #2871 where
|
There was a problem hiding this comment.
Clean, correct fix. The git remote set-url step is placed exactly where it needs to be — after the App token is generated and before changesets/action pushes commits. This matches the established pattern in ci.yml and auto-format.yml. The token is safely passed via env: (not string-interpolated), and the unconditional execution is appropriate since this workflow only runs on push to main or workflow_dispatch (never fork PRs).
Claude Opus | 𝕏
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
This PR adds the git remote set-url configuration step to the release workflow, ensuring commits pushed by changesets/action use the App token and properly trigger downstream CI workflows.
Analysis
Pattern consistency: ✅ The implementation exactly matches the established pattern already used in:
Placement: ✅ Correctly positioned after Generate GitHub App Token step and before changesets/action — the token must be available before it's used.
Security: ✅ Token is passed via environment variable (APP_TOKEN), not hardcoded. Uses the existing inkeep-internal-ci App credentials.
Problem solved: This addresses the root cause of PR #2881's stuck checks — without the App token in the remote URL, GitHub's infinite loop prevention ignores the push for workflow triggering purposes.
✅ APPROVE
Summary: Clean, minimal fix that follows the established pattern from PR #2871. The change is correctly placed, uses secure credential handling, and directly addresses the CI workflow triggering issue.
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
orchestrator |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
Note: No sub-reviewers dispatched — this is a minimal CI workflow change following an established pattern.
The changesets/action pushes commits using the default GITHUB_TOKEN credential, which GitHub ignores for triggering downstream workflows. This left the Version Packages PR (#2881) stuck with required checks (ci, Cypress E2E, Create Agents E2E) permanently waiting. Configures the git remote URL with the inkeep-internal-ci App token before changesets/action runs — same pattern applied to ci.yml and auto-format.yml in #2871. Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
Summary
changesets/actioninrelease.ymlpushes commits to thechangeset-release/mainbranch using the defaultGITHUB_TOKENcredential, which GitHub ignores for triggering downstream workflows (infinite loop prevention)ci,Cypress E2E Tests,Create Agents E2E Tests) permanently at "Waiting for status to be reported"inkeep-internal-ciApp token beforechangesets/actionruns, same pattern applied toci.ymlandauto-format.ymlin fix(ci): use GitHub App token for auto-commits to trigger CI #2871Test plan
changeset-release/mainpush triggers CI workflows🤖 Generated with Claude Code