Skip to content

fix for restart endpoint#2917

Merged
shagun-singh-inkeep merged 1 commit intomainfrom
fix-workflow-restart
Mar 30, 2026
Merged

fix for restart endpoint#2917
shagun-singh-inkeep merged 1 commit intomainfrom
fix-workflow-restart

Conversation

@shagun-singh-inkeep
Copy link
Copy Markdown
Collaborator

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agents-api Ready Ready Preview, Comment Mar 30, 2026 9:31pm
agents-docs Ready Ready Preview, Comment Mar 30, 2026 9:31pm
agents-manage-ui Ready Ready Preview, Comment Mar 30, 2026 9:31pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 30, 2026

⚠️ No Changeset found

Latest commit: 263e975

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, correct one-liner. Using the stable production URL from secrets.INKEEP_AGENTS_API_URL instead of the deployment-specific needs.deploy-agents-api.outputs.url is the right call — restart-scheduler runs after promote, so the request should target the promoted production domain rather than a potentially ephemeral deployment URL.

Pullfrog  | View workflow run | Using Claude Opus𝕏

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Mar 30, 2026

TL;DR — Fixes the scheduler restart step in the Vercel production deploy workflow by using a stable secret-based URL instead of the deployment output URL, which may not be ready to receive requests immediately after deploy.

Key changes

  • Use INKEEP_AGENTS_API_URL secret for scheduler restart endpoint — Replaces the dynamic needs.deploy-agents-api.outputs.url with the stable secrets.INKEEP_AGENTS_API_URL so the restart call always hits the known production API origin.

Summary | 1 file | 1 commit | base: mainfix-workflow-restart

Before: The restart-scheduler curl call used the freshly deployed URL from the deploy-agents-api job output, which could be a preview/deployment-specific URL not yet fully propagated.
After: The call uses the INKEEP_AGENTS_API_URL repository secret — a stable, known-good production URL that is always routable.

.github/workflows/vercel-production.yml

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Claude Opus𝕏

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

Analysis

This is a correct and well-reasoned fix. The change replaces a dynamic Vercel deployment URL with a stable, secret-based production URL for the scheduler restart endpoint.

Why this is correct:

  1. Timing issue fixed: The restart-scheduler job runs after the promote job completes. At that point, the production URL (stored in INKEEP_AGENTS_API_URL) is already serving the newly-promoted deployment. Using the stable production URL ensures the restart call reaches the correct instance.

  2. Reliability improvement: The previous approach used the specific deployment URL output (needs.deploy-agents-api.outputs.url), which is a transient Vercel deployment URL (e.g., https://agents-api-abc123.vercel.app). After promotion, the production URL is the canonical entry point, making it more reliable to call.

  3. Security preserved: Authorization continues to use the bearer token from secrets (INKEEP_AGENTS_RUN_API_BYPASS_SECRET), maintaining proper access control.

🧹 While You're Here (1) 🧹

🧹 1) vercel-production.yml:9-15 Missing secret documentation

Issue: The workflow header documents required secrets but omits INKEEP_AGENTS_API_URL and INKEEP_AGENTS_RUN_API_BYPASS_SECRET, both used by the restart-scheduler job.

Why: Future maintainers setting up or troubleshooting this workflow may miss configuring these secrets.

Fix: Consider adding to the header comment in a future PR:

# - INKEEP_AGENTS_API_URL: Stable production API URL for scheduler restart endpoint
# - INKEEP_AGENTS_RUN_API_BYPASS_SECRET: Bearer token for internal deployment endpoints

Refs: vercel-production.yml:9-15


✅ APPROVE

Summary: Clean, correct fix. The change from dynamic deployment URL to stable production URL is appropriate for the scheduler restart endpoint that runs post-promotion. No blocking issues found. 🚀

Reviewers (2)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
pr-review-devops 1 0 0 1 0 0 0
pr-review-standards 0 0 0 0 0 0 0
Total 1 0 0 1 0 0 0

@github-actions github-actions Bot deleted a comment from claude Bot Mar 30, 2026
@shagun-singh-inkeep shagun-singh-inkeep added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 722ad5c Mar 30, 2026
23 of 24 checks passed
@shagun-singh-inkeep shagun-singh-inkeep deleted the fix-workflow-restart branch March 30, 2026 21:48
tim-inkeep pushed a commit that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants