fix for restart endpoint#2917
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
Clean, correct one-liner. Using the stable production URL from secrets.INKEEP_AGENTS_API_URL instead of the deployment-specific needs.deploy-agents-api.outputs.url is the right call — restart-scheduler runs after promote, so the request should target the promoted production domain rather than a potentially ephemeral deployment URL.
Claude Opus | 𝕏
|
TL;DR — Fixes the scheduler restart step in the Vercel production deploy workflow by using a stable secret-based URL instead of the deployment output URL, which may not be ready to receive requests immediately after deploy. Key changes
Summary | 1 file | 1 commit | base:
|
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Analysis
This is a correct and well-reasoned fix. The change replaces a dynamic Vercel deployment URL with a stable, secret-based production URL for the scheduler restart endpoint.
Why this is correct:
-
Timing issue fixed: The
restart-schedulerjob runs after thepromotejob completes. At that point, the production URL (stored inINKEEP_AGENTS_API_URL) is already serving the newly-promoted deployment. Using the stable production URL ensures the restart call reaches the correct instance. -
Reliability improvement: The previous approach used the specific deployment URL output (
needs.deploy-agents-api.outputs.url), which is a transient Vercel deployment URL (e.g.,https://agents-api-abc123.vercel.app). After promotion, the production URL is the canonical entry point, making it more reliable to call. -
Security preserved: Authorization continues to use the bearer token from secrets (
INKEEP_AGENTS_RUN_API_BYPASS_SECRET), maintaining proper access control.
🧹 While You're Here (1) 🧹
🧹 1) vercel-production.yml:9-15 Missing secret documentation
Issue: The workflow header documents required secrets but omits INKEEP_AGENTS_API_URL and INKEEP_AGENTS_RUN_API_BYPASS_SECRET, both used by the restart-scheduler job.
Why: Future maintainers setting up or troubleshooting this workflow may miss configuring these secrets.
Fix: Consider adding to the header comment in a future PR:
# - INKEEP_AGENTS_API_URL: Stable production API URL for scheduler restart endpoint
# - INKEEP_AGENTS_RUN_API_BYPASS_SECRET: Bearer token for internal deployment endpointsRefs: vercel-production.yml:9-15
✅ APPROVE
Summary: Clean, correct fix. The change from dynamic deployment URL to stable production URL is appropriate for the scheduler restart endpoint that runs post-promotion. No blocking issues found. 🚀
Reviewers (2)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-devops |
1 | 0 | 0 | 1 | 0 | 0 | 0 |
pr-review-standards |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
| Total | 1 | 0 | 0 | 1 | 0 | 0 | 0 |
No description provided.