🦋 Changeset detected

Latest commit: 8fe313d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agents-api	Ready	Preview, Comment	Mar 31, 2026 8:15pm
agents-manage-ui	Ready	Preview, Comment	Mar 31, 2026 8:15pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
agents-docs	Skipped		Mar 31, 2026 8:15pm

TL;DR — Fixes false positive "Needs Login" status on MCP server detail pages by introducing a three-tier error classification. Transient server errors (5xx, timeouts, network failures) and unknown errors when a valid credential exists now resolve to unavailable instead of needs_auth, reserving the login prompt for genuine auth failures (401/403, UnauthorizedError).

Key changes

• Add isAuthenticationError() classifier in tools.ts — Detects 401/403 StreamableHTTPError, UnauthorizedError, and auth-related message patterns to distinguish genuine credential failures from transient issues.
• Expand isTimeoutOrConnectionError() to cover more transient failures — Now includes McpError(InternalError), StreamableHTTPError 5xx, fetch failed, ECONNREFUSED, ENOTFOUND, EHOSTUNREACH, ENETUNREACH, and EPIPE.
• Add credential-aware fallback in dbResultToMcpTool catch block — Unknown errors with an existing credential are treated as unavailable (with a warning log) rather than triggering OAuth detection.
• Add 9 unit tests for three-tier error classification — Covers every branch: transient errors, auth errors, credential-present fallback, and no-credential OAuth detection.

_{Summary ｜ 3 files ｜ 1 commit ｜ base: main ← false-positive-needs-auth}

Three-tier error classification for MCP server status

Before: Any connection error during MCP tool discovery could trigger needs_auth status, even when the user had a valid credential and the server returned a transient 500 error.
After: Errors are classified into three tiers: (1) transient → unavailable, (2) auth (401/403/UnauthorizedError) → needs_auth, (3) unknown with existing credential → unavailable. Only genuine auth failures or OAuth detection without a credential can set needs_auth.

The new isAuthenticationError() function checks for UnauthorizedError from the MCP SDK, StreamableHTTPError with 401/403 status codes, and error messages containing auth-related keywords (unauthorized, forbidden, invalid_token, token expired, invalid_grant). The existing isTimeoutOrConnectionError() is expanded to recognize McpError(InternalError), StreamableHTTPError 5xx, fetch failed messages, and network error codes like ECONNREFUSED and ENOTFOUND.

The catch block in dbResultToMcpTool now evaluates errors in priority order: transient first, then explicit auth errors, then a credential-aware fallback that logs a warning and returns unavailable rather than falling through to OAuth detection.

When does OAuth detection still run?

OAuth detection via detectAuthenticationRequired() only runs when (a) the error is not transient, (b) the error is not an explicit auth error, and (c) there is no existing credential. This is the only remaining path to needs_auth for non-explicit-auth errors.

tools.ts · dbResultToMcpTool.test.ts

  ^{｜ View workflow run ｜ Triggered by Pullfrog ｜ Using Claude Opus ｜ 𝕏}

Ito Test Report ✅

10 test cases ran. 10 passed.

The unified run passed all 10 of 10 test cases with zero failures, confirming expected MCP detail/list behavior, create flow behavior, security handling, and permission boundaries. Most importantly, transient credentialed failures consistently rendered as Unavailable (not Needs Login), explicit or missing-auth states correctly showed Needs Login with Connect (including single OAuth start on rapid clicks), loading states converged to Unavailable without regression, user-scoped custom server creation preserved stable Needs Login on first load/reload, XSS and unsafe URL inputs were safely blocked or rendered inert, and the view-only authorization concern was validated as a permission-simulation artifact rather than a confirmed product defect.

✅ Passed (10)

Category	Summary	Screenshot
Adversarial	Injected script-like payloads in tool name/lastError rendered inert with no script execution side effects.
Adversarial	Invalid javascript:, data:, and malformed URL inputs were rejected and did not submit create requests.
Adversarial	Authorization-boundary finding was resolved as a permission-simulation artifact; code-level guards indicate expected server-side protection.
Edge	Rapid repeated Connect clicks triggered only one OAuth start.
Edge	Credentialed unavailable project tool still exposes disconnect/delete action.
Logic	Composio tool without connectedAccountId correctly shows Needs Login with Connect CTA.
Happy-path	Credentialed transient-failure detail view showed Unavailable (not Needs Login), with no Connect CTA.
Happy-path	Project- and user-scoped auth failures showed Needs Login with Connect CTA, and OAuth start was initiated on click.
Happy-path	Deterministic re-validation showed list/detail convergence from loading to Unavailable with no Needs Login regression.
Happy-path	User-scoped custom MCP server creation redirected to detail and showed stable Needs Login + Connect behavior on first load and reload.

Commit: bf358c2

View Full Run

Tell us how we did: Give Ito Feedback

No documentation changes needed for this PR. The fix improves the internal accuracy of status classification (transient errors → unavailable vs auth errors → needs_auth), but the user-facing status values documented in the MCP Servers guide remain the same.

Ito Test Report ✅

13 test cases ran. 2 additional findings, 11 passed.

Overall, 11 of 13 test cases passed, confirming that MCP status and auth-state handling is largely correct across list/details, navigation refresh loops, mobile viewport, deep-link stale-state scenarios, and API boundary checks (including query tampering rejection and unauthorized tenant/project access protection), with transient failures on already-credentialed tools consistently shown as Unavailable and true auth failures (401/403 or OAuth-required without credentials) shown as Needs Login with expected Connect behavior. The two confirmed defects were a high-severity race where rapid repeated Connect clicks can start duplicate OAuth launches before the disabled/loading state applies, and a medium-severity Composio error-handling issue where auth-check service failures can be misclassified as Needs Login instead of Unavailable, leading to unnecessary reconnect prompts.

✅ Passed (11)

Category	Summary	Screenshot
Adversarial	Valid enum filtering returned constrained results, while tampered status values were rejected with 400 validation responses.
Adversarial	Unauthorized tenant/project probes were rejected and did not expose tool status or credential metadata.
Adversarial	Two-tab deep-link stale-state checks converged to Unavailable on details/list with project connection preserved and no false login prompt.
Edge	Across repeated details/back/forward/refresh loops, the transient credentialed MCP server consistently resolved to Unavailable and did not settle on Needs Login.
Edge	At iPhone 13 viewport, the list and details views preserved Unavailable status and key connection/error sections without losing controls; no unexpected Connect prompt appeared.
Logic	401/403 fixtures were classified as Needs Login on list and details, with reconnect/connect affordance visible.
Logic	No-credential OAuth-required fixture stayed in Needs Login with a single Connect initiation request and no duplicate launch.
Logic	No-credential unknown non-auth failure remained unhealthy on details/list, with no Connect CTA and no auth wording in Last Error.
Happy-path	List and both details views showed Unavailable with credential context; no reconnect prompts appeared.
Happy-path	Project details kept Project Connection visible while status remained Unavailable and Connect stayed hidden.
Happy-path	User details showed Unavailable with Your Connection card and no Connect/re-auth prompt.

ℹ️ Additional Findings (2)

These findings are unrelated to the current changes but were observed during testing.

Category	Summary	Screenshot
Edge	⚠️ Rapid Connect clicks can trigger duplicate OAuth initiation before the disabled/loading state takes effect.
Edge	🟠 Composio auth-check service failures can be classified as Needs Login instead of degrading to Unavailable.

const handleOAuthLogin = useCallback(
  async ({
    toolId,
    mcpServerUrl,
    toolName,
    thirdPartyConnectAccountUrl,
    credentialScope,
  }: OAuthLoginParams): Promise<void> => {
    setIsConnecting(true);
    try {
      if (mcpServerUrl.includes('composio.dev')) {
        // ...
      }
      // ...
    } finally {
      setIsConnecting(false);
    }
  },
);

<Button
  size="sm"
  className="mt-3 w-fit"
  disabled={isConnecting}
  onClick={() => {
    handleOAuthLogin({
      toolId: tool.id,
      mcpServerUrl: tool.config.mcp.server.url,
      toolName: tool.name,
      credentialScope: 'project',
    });
  }}
>

async function fetchComposioConnectedAccounts(
  derivedUserId: string
): Promise<Awaited<ReturnType<Composio['connectedAccounts']['list']>> | null> {
  // ...
  try {
    const connectedAccounts = await composioInstance.connectedAccounts.list({
      userIds: [derivedUserId],
      statuses: ['ACTIVE', 'INITIATED', 'EXPIRED'],
    });
    return connectedAccounts;
  } catch (error) {
    logger.error({ error }, 'Error fetching Composio connected accounts');
    return null;
  }
}

try {
  const [composioMcpServer, connectedAccounts] = await Promise.all([
    composioInstance.mcp.get(serverId),
    fetchComposioConnectedAccounts(composioUserId),
  ]);

  if (!firstAuthConfigId) {
    return { authenticated: false };
  }

  if (!connectedAccounts) {
    return { authenticated: false };
  }

if (!authResult.authenticated && !authResult.error) {
  status = 'needs_auth';
  lastErrorComputed = 'Third-party authentication required. Try authenticating again.';
} else if (authResult.error) {
  status = 'unavailable';
  lastErrorComputed =
    'Could not verify third-party authentication status. The service may be temporarily unavailable.';
}

Commit: 8fe313d

View Full Run

Tell us how we did: Give Ito Feedback