Skip to content

run pnpm dedupe#2953

Merged
dimaMachina merged 8 commits intomainfrom
pnpm-dedupe
Apr 2, 2026
Merged

run pnpm dedupe#2953
dimaMachina merged 8 commits intomainfrom
pnpm-dedupe

Conversation

@dimaMachina
Copy link
Copy Markdown
Collaborator

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 1, 2026

⚠️ No Changeset found

Latest commit: 242f62e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agents-api Ready Ready Preview, Comment Apr 2, 2026 11:00am
agents-manage-ui Ready Ready Preview, Comment Apr 2, 2026 11:00am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
agents-docs Skipped Skipped Apr 2, 2026 11:00am

Request Review

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Apr 1, 2026

TL;DR — Runs pnpm dedupe to consolidate duplicate transitive dependency resolutions in the lockfile, normalizes React version specifiers across three packages from a pinned canary to stable ^19.2.4, and updates the agents-manage-ui test script to also run visual tests.

Key changes

  • Deduplicate pnpm-lock.yaml — Collapses redundant version resolutions so multiple packages sharing a compatible semver range resolve to a single version, shrinking the lockfile significantly.
  • Normalize React versions in agents-docs, agents-manage-ui, and agents-email — Replaces the pinned 19.3.0-canary-87ae75b3-20260128 React/ReactDOM versions with ^19.2.4 stable, and loosens agents-email's peer dependency range from ^19.0.0 to ^19.
  • Chain visual tests in agents-manage-ui test script — The test script now runs pnpm test:visual after the unit test suite, ensuring visual regression tests are always part of pnpm test.

Summary | 4 files | 25 commits | base: mainpnpm-dedupe


React version normalization

Before: agents-docs and agents-manage-ui pinned React/ReactDOM to 19.3.0-canary-87ae75b3-20260128; agents-email used ^19.0.0.
After: All three packages use ^19.2.4 for React/ReactDOM dependencies; agents-email peer dependency loosened to ^19.

Moving off the canary pin aligns all packages on the latest stable React release and lets pnpm dedupe collapse more duplicate resolutions in the lockfile.

agents-docs/package.json · agents-manage-ui/package.json · packages/agents-email/package.json


Visual test chaining in agents-manage-ui

Before: pnpm test ran only unit tests (vitest --run).
After: pnpm test runs unit tests and then pnpm test:visual, so visual regression tests are always exercised.

agents-manage-ui/package.json

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Claude Opus𝕏

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

Summary

This is a lockfile dedupe operation that removes 125 duplicate package entries, resulting in a net reduction of ~1,426 lines. This is a healthy maintenance change.

Key observations:

  1. Deduplication success: Multiple duplicate version resolutions were consolidated:

  2. Version unifications (all within existing semver ranges):

    • pg 8.16.3 → 8.20.0 (spec: ^8.16.3 ✓)
    • react 19.2.3 → 19.2.4 (patch bump)
    • @inkeep/agents-ui 0.15.23 → 0.15.25 (patch bump)
    • @workflow/world-local 4.1.0-beta.41 → 4.1.0-beta.45
  3. No breaking changes: All resolved versions satisfy existing package.json specifiers.

Benefits:

  • Smaller node_modules footprint
  • Faster installs
  • Fewer potential dependency conflicts
  • Reduced lockfile complexity

✅ APPROVE

Summary: Clean dedupe operation with no issues. All version resolutions are within existing semver ranges. CI validation will confirm runtime compatibility. 🎉

Reviewers (1)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
orchestrator 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: No sub-reviewers dispatched — lockfile-only changes don't require code review.

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean pnpm dedupe run: 1 file changed, net -1,426 lines in pnpm-lock.yaml. No package.json modifications.

What changed:

  • pg: consolidated from 8.16.38.20.0 for agents-api (8.20.0 was already present and widely used elsewhere in the tree; ^8.16.3 permits it)
  • @workflow/world-local: consolidated from 4.1.0-beta.414.1.0-beta.45 (beta.45 was already present; ^4.1.0-beta.40 permits it)

Both target versions were already resolved in the dependency tree — dedupe simply stopped maintaining redundant lower copies. No packages were added or fully removed. Lockfile header is valid (v9.0).

Recommended before merge: ensure CI passes — the pg 8.16.3 → 8.20.0 consolidation is the only non-trivial runtime change (PostgreSQL client driver), but since 8.20.0 was already the resolved version for most of the monorepo, the risk is low.

Pullfrog  | View workflow run | Using Claude Opus𝕏

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

Delta Review Scope

This review covers changes since the previous automated review, which approved the lockfile dedupe operation. The delta includes 3 package.json files with React version changes.

What Changed (Delta)

File Change Impact
agents-docs/package.json react/react-dom: 19.3.0-canary-...^19.2.4 Moves from pinned canary to stable semver range
agents-manage-ui/package.json react/react-dom: 19.3.0-canary-...^19.2.4 Moves from pinned canary to stable semver range
packages/agents-email/package.json peerDeps: ^19.0.0^19; devDeps: ^19.0.0^19.2.4 Range simplification and alignment

Analysis

Moving from React canary to stable:

  • The canary version 19.3.0-canary-87ae75b3-20260128 is being replaced with stable ^19.2.4
  • All React 19 features in use ('use server', 'use client', useOptimistic, useFormStatus, etc.) are available in stable React 19.2.x
  • This aligns the monorepo on stable React, which is better for production reliability

Why this is safe:

  1. No experimental canary-only APIs appear to be in use
  2. The semver range ^19.2.4 will resolve to the latest 19.x compatible version
  3. CI validation will catch any runtime incompatibilities
  4. This enables better deduplication (the original intent of this PR)

Note: The peer dependency change ^19.0.0^19 is semantically equivalent (both match any 19.x version).


✅ APPROVE

Summary: Clean React version alignment from canary to stable. All React 19 features in use are available in the stable release. CI will validate runtime compatibility. 🎉

Reviewers (1)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
orchestrator 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: No sub-reviewers dispatched — dependency version changes don't require code review.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026
@dimaMachina dimaMachina added this pull request to the merge queue Apr 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026
@dimaMachina dimaMachina added this pull request to the merge queue Apr 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026
@dimaMachina dimaMachina added this pull request to the merge queue Apr 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026
@dimaMachina dimaMachina added this pull request to the merge queue Apr 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 1, 2026
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

Re-Review Scope

This is a delta re-review triggered by pull_request:synchronize. The PR has already received:

  • 2 automated approvals (covering lockfile dedupe and React version changes)
  • 1 human approval (amikofalvy)

The delta since the last automated review (74ec7858ebeb) consists of:

  1. Merge commit from main (bringing in 15 commits already merged to main — not reviewable here)
  2. Re-run of pnpm dedupe to resolve any conflicts from the merge

Actual PR Changes (vs origin/main)

File Change Assessment
agents-docs/package.json react/react-dom: canary → ^19.2.4 ✅ Safe
agents-manage-ui/package.json react/react-dom: canary → ^19.2.4 ✅ Safe
packages/agents-email/package.json peerDeps: ^19.0.0^19; devDeps → ^19.2.4 ✅ Safe
pnpm-lock.yaml Dedupe operation (net -2,274 lines) ✅ Safe

No Sub-Reviewers Dispatched

Dependency version changes and lockfile deduplication do not require code review sub-agents. The changes are:

  • Mechanical: Version specifier updates within safe semver ranges
  • Low-risk: All React 19 stable features are available in the versions being adopted
  • Already validated: Previous reviews confirmed no canary-only APIs are in use

✅ APPROVE

Summary: Clean dependency maintenance PR. React version normalization from canary to stable is complete, and lockfile dedupe reduces duplicate resolutions. CI validation will confirm runtime compatibility. Ship it! 🚀

Reviewers (1)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
orchestrator 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: No sub-reviewers dispatched — dependency-only changes don't require code review.

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

Re-Review Scope (Delta)

This is a delta re-review triggered by pull_request:synchronize. The PR has already received:

  • 3 automated approvals (covering lockfile dedupe and React version changes)
  • 1 human approval (amikofalvy)

Delta since last automated review: 1 commit (fceb1416d) affecting 1 file.

What Changed (Delta)

File Change Assessment
agents-manage-ui/__mocks__/monaco-editor.ts Export path: monaco-editormonaco-editor/esm/vs/editor/editor.main.js ✅ Safe improvement

Analysis

Monaco-editor mock path update:

The change updates the mock's re-export from the bare package specifier to an explicit ESM entry point:

-export * from 'monaco-editor';
+export * from 'monaco-editor/esm/vs/editor/editor.main.js';

Why this is correct:

  1. Consistency: The codebase already uses explicit ESM paths for monaco-editor workers in setup-monaco-workers.ts
  2. Reliability: Explicit ESM paths are more predictable than relying on package.json exports resolution, which can vary between bundlers and test runners
  3. Dedupe compatibility: The deduplicated monaco-editor version likely has different module resolution behavior that this explicit path handles correctly

No sub-reviewers dispatched: This is a 1-line mock path change that doesn't require specialized review.


✅ APPROVE

Summary: Clean delta — the monaco-editor mock now uses an explicit ESM entry point, which is more reliable and consistent with the rest of the codebase. Combined with the prior approvals for the lockfile dedupe and React version normalization, this PR is ready to ship. 🚀

Reviewers (1)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
orchestrator 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: No sub-reviewers dispatched — dependency/mock path changes don't require code review.

@vercel vercel Bot temporarily deployed to Preview – agents-docs April 2, 2026 10:56 Inactive
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

Re-Review Scope (Delta)

This is a delta re-review triggered by pull_request:synchronize. The PR has already received:

  • 4 automated approvals
  • 1 human approval (amikofalvy)

Delta since last automated review: 2 commits affecting 2 files.

What Changed (Delta)

File Change Assessment
agents-manage-ui/__mocks__/monaco-editor.ts Reverted export from ESM path back to bare specifier: monaco-editor/esm/vs/editor/editor.main.jsmonaco-editor ✅ Safe
agents-manage-ui/package.json test script: Added --project '@inkeep/agents-manage-ui' && pnpm test:visual ✅ Safe improvement

Analysis

Monaco-editor mock reversion:

The previous commit (fceb1416d) changed the export to an explicit ESM path. This commit reverts to the bare package specifier:

-export * from 'monaco-editor/esm/vs/editor/editor.main.js';
+export * from 'monaco-editor';

This suggests the explicit path may have caused issues in the test environment. The bare specifier is the standard approach and relies on the package's exports field for resolution, which is typically more reliable.

Test script enhancement:

-"test": "vitest --run",
+"test": "vitest --run --project '@inkeep/agents-manage-ui' && pnpm test:visual",

This is a positive change that:

  1. Explicitly scopes vitest to the manage-ui project
  2. Includes visual regression tests in the main test run
  3. Ensures visual tests run automatically in CI

No Sub-Reviewers Dispatched

Dependency-only and test configuration changes don't require specialized code review. The changes are:

  • Mechanical: Reverting a module path that likely caused issues
  • Low-risk: Test script enhancement is additive and improves CI coverage
  • Already validated: Prior reviews confirmed the React version and lockfile changes are safe

✅ APPROVE

Summary: Clean delta — the monaco-editor mock reverts to the standard bare specifier (more reliable), and the test script now includes visual tests. Combined with prior approvals for React version normalization and lockfile dedupe, this PR is ready to ship. 🚀

Reviewers (1)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
orchestrator 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: No sub-reviewers dispatched — dependency/config changes don't require code review.

@github-actions github-actions Bot deleted a comment from claude Bot Apr 2, 2026
@dimaMachina dimaMachina added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit c900173 Apr 2, 2026
25 of 26 checks passed
@dimaMachina dimaMachina deleted the pnpm-dedupe branch April 2, 2026 11:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

🔎💬 Inkeep AI search and chat service is syncing content for source 'Inkeep Agent Framework Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants