enable enableJsxOutlining in React compiler config#3020
enable enableJsxOutlining in React compiler config#3020dimaMachina wants to merge 31 commits intomainfrom
enableJsxOutlining in React compiler config#3020Conversation
Co-authored-by: Dimitri POSTOLOV <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Preview URLsUse these stable preview aliases for testing this PR:
These point to the same Vercel preview deployment as the bot comment, but they stay stable and easier to find. Raw Vercel deployment URLs
|
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Ito Test Report ❌15 test cases ran. 7 failed, 8 passed. Across 15 test cases, 8 passed and 7 failed, with the dominant and highest-impact issue a PR-introduced React compiler regression (enableJsxOutlining enabled while panicThreshold='all_errors') that causes deterministic transform/parse failures in shared Manage UI TSX modules (notably model-configuration.tsx and output-schema-filters.tsx), leading to route crashes and even a critical HTTP 500 on /login that blocks project settings, agent/sub-agent model editing, and related configuration workflows. When the UI was executable (often under local compile-stability bypasses), key behaviors validated successfully: malformed provider-options JSON was safely rejected with last valid state preserved, XSS-like provider-options payloads remained inert, rage-click and stale-tab save races converged coherently, agent metadata and unsaved-change navigation behaved correctly, and the docs compiler smoke and protected-route auth/session deep-link checks showed no product defect. ❌ Failed (7)🚨 Manage UI fails to compile on login due React compiler transform errors
Relevant code:
@@ -84356,7 +84356,7 @@ var EnvironmentConfigSchema = external_exports.object({
* With this change, when `countries` is updated by adding one single value,
* only the newly added value is re-rendered and not the entire list.
*/
- enableJsxOutlining: external_exports.boolean().default(false),
+ enableJsxOutlining: external_exports.boolean().default(true),
/*
const AllowedProvidersSection: FC<{
allowedProviders?: string[];
inheritedAllowedProviders?: string[];
onAllowedProvidersChange: (providers: string[]) => void;
disabled: boolean;
}> = ({ allowedProviders, inheritedAllowedProviders, onAllowedProvidersChange, disabled }) => {
{filters.map((filter, index) => (
<div key={index} className="flex gap-2 items-center">
<div className="flex-1 min-w-[200px]">
<Select
value={filter.key || 'none'}
onValueChange={(value) =>
updateFilter(index, 'key', value === 'none' ? '' : value)
}
>
<SelectTrigger className="bg-background">
<SelectValue placeholder="Select field" />
</SelectTrigger>
|
3e31625 to
7de42e5
Compare
Ito Test Report ❌14 test cases ran. 1 failed, 13 passed. The unified run executed 14 test cases with 13 passes and 1 failure, confirming strong coverage across auth and routing behavior (unauthenticated/login redirects, authenticated root to /default/projects, deep-link intent preservation, returnUrl loop handling, refresh recovery), security hardening (malicious/injected returnUrl and invitation payloads contained, cross-tenant URL tampering denied), docs safety (valid slug rendering plus safe 404/traversal handling), and navigation resilience under rapid repeated project-card clicks. The single blocker is a high-severity, PR-introduced regression where enabling JSX outlining by default causes compile-time failures in Manage UI components (including model-configuration.tsx and output-schema-filters.tsx), producing HTTP 500 errors on /default/projects in mobile viewport (390x844) and preventing the core project → agent → Try it playground flow. ❌ Failed (1)
|
blocked by facebook/react#36217 facebook/react#36218
closes #2806