Merged
Conversation
Member
|
Apologies for the long delay, and thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get a lot of people asking about Find and Replace in the Ink discord, which indicates it's not a feature that's very obviously surfaced.
Find and Replace in Inky does, in fact, exist, and is provided by the Ace editor that Inky is built on. It's just not on a very intuitive keyboard shortcut - Ctrl+H - and at the moment there's no way to know this except through trial and error keyboard mashing or by googling "Ace editor keyboard shortcuts", which...also isn't intuitive.
What I wanted to do was hook up Find and Replace to the menu directly, but unfortunately, after a day or so of trying to do this, I couldn't find a way to do this that was achievable by me, and/or wouldn't break the next time we updated the ace editor library!
So, rather than introducing a lot of spaghetti for a feature that already exists, I was thinking we could put a list of keyboard shortcuts in the place people will first look when searching for a Find and Replace function: in the edit menu.
The menu that appears is ugly but functional, and should tell people everything they want to know about find and replace (and a bit more).
It's been implemented in the exact same way that the story stats menu option was, which you can see below here:
With luck, this should reduce the amount of people who need to go to the Ink discord to find out how to Find and Replace in Inky!