Skip to content

Relax numba pin from >=0.62.0 to >=0.61.2#702

Merged
Maxusmusti merged 1 commit intoinstructlab:mainfrom
Maxusmusti:relax-numba-pin
Apr 23, 2026
Merged

Relax numba pin from >=0.62.0 to >=0.61.2#702
Maxusmusti merged 1 commit intoinstructlab:mainfrom
Maxusmusti:relax-numba-pin

Conversation

@Maxusmusti
Copy link
Copy Markdown
Collaborator

@Maxusmusti Maxusmusti commented Apr 23, 2026 •
edited by coderabbitai Bot
Loading

Summary

Relaxes the numba version pin from >=0.62.0 to >=0.61.2 to resolve a dependency conflict with vllm, which pins numba==0.61.2.

The numba usage in this project (basic @njit decorators and int64 types) is fully compatible with numba 0.61.x — no 0.62-specific APIs are used.

Motivation

When installing alongside vllm<=0.15.1 (used by verl for GRPO training), pip/uv cannot satisfy both numba>=0.62.0 and vllm's numba==0.61.2 pin, causing dependency resolution failures.

Summary by CodeRabbit

  • Chores
    • Reduced minimum Numba version requirement to improve compatibility with existing environments.

@Maxusmusti @claude
Relax numba pin from >=0.62.0 to >=0.61.2
8e35c48 
Resolves dependency conflict with vllm which pins numba==0.61.2.
No 0.62-specific APIs are used.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@mergify mergify Bot added the dependencies Pull requests that update a dependency file label Apr 23, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a78233a8-712f-474b-be6e-f5d019c58c59

📥 Commits

Reviewing files that changed from the base of the PR and between 2c93507 and 8e35c48.

📒 Files selected for processing (1)
  • requirements.txt
📝 Walkthrough

Walkthrough

The pull request lowers the minimum required version of the numba dependency from 0.62.0 to 0.61.2 in requirements.txt. This change allows the project to work with an older version of the library while maintaining compatibility.

Changes

Cohort / File(s) Summary
Dependency Version Constraint
requirements.txt		 Lowered numba minimum version requirement from 0.62.0 to 0.61.2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version so small did we lower today,
Numba's constraint in a gentler way,
From 0.62 down to 0.61.2 we go,
Compatibility blooms where dependencies flow! 🌿✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: relaxing the numba dependency pin from >=0.62.0 to >=0.61.2, which is the sole modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

RobotSail
RobotSail approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify Bot added the one-approval label Apr 23, 2026
@Maxusmusti Maxusmusti merged commit 73ecf57 into instructlab:main Apr 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobotSail RobotSail RobotSail approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file one-approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Maxusmusti @RobotSail