This repository was archived by the owner on Mar 5, 2022. It is now read-only.
Work additionally with Python 3.x#4
Merged
jarun merged 1 commit intojarun:masterfrom Aug 25, 2015
Narrat:support/py3
Merged
Conversation
Changes:
* use the print function from Future. Print statements would have worked with parenthesis around it, but not if the , param was used (print("", end='')).
* Change in string and input handling made it necessary to differ between py versions
* Module loading. Some module names changed. Catched via trial and error
Contributor
Author
|
Because of encoding issues that will arise I prepared another commit and branch, but I wait until this got merged, or not. Commit: https://github.com/Narrat/google-cli/commit/429dccac6ea5e1a390faed47de867f421a6f7c56 |
jarun
added a commit
that referenced
this pull request
Aug 25, 2015
Work additionally with Python 3.x
Owner
|
Seems clean in my tests. Thank you! |
Owner
|
Please raise the pull request for the encoding change. Just make sure that it doesn't break the existing search options (-s, -n, -f, -t) and navigation. |
jarun
added a commit
that referenced
this pull request
Mar 9, 2016
Work additionally with Python 3.x
john-peterson
pushed a commit
to john-peterson/googler
that referenced
this pull request
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Necessary changes to make it work with py2 and py3.
Please test it thoroughly before merging in case I forgot something to change. For me it worked with py2 and py3, but you never know