bugfix: renamed manga character container class#368
Merged
irfan-dahir merged 1 commit intojikan-me:masterfrom Oct 19, 2021
Merged
bugfix: renamed manga character container class#368irfan-dahir merged 1 commit intojikan-me:masterfrom
irfan-dahir merged 1 commit intojikan-me:masterfrom
Conversation
Contributor
Author
|
Oh, for why this is necessary in the first place, characters for manga currently returns nothing: https://api.jikan.moe/v3/manga/1/characters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAL changed the container class on the manga character page
from
anime-container-classtomanga-container-classSee source here; https://myanimelist.net/manga/1/_/characters
Seems all the CharacterListItemParser code is unaffected, since it didn't
depend on anime or manga class items on the page