Skip to content

bugfix/userlist: add genre/demographic IDs to URL#369

Merged
irfan-dahir merged 1 commit intojikan-me:masterfrom
purarue:userlist-genre-ids
Oct 21, 2021
Merged

bugfix/userlist: add genre/demographic IDs to URL#369
irfan-dahir merged 1 commit intojikan-me:masterfrom
purarue:userlist-genre-ids

Conversation

@purarue
Copy link
Copy Markdown
Contributor

@purarue purarue commented Oct 21, 2021 •
edited
Loading

On a request like https://api.jikan.moe/v3/user/QCTFW/animelist

Currently it looks like:

{
  "genres": [
        {
          "mal_id": 0,
          "type": "anime",
          "name": "Comedy",
          "url": "https://myanimelist.net/anime/genre/Comedy"
        },
        {
          "mal_id": 0,
          "type": "anime",
          "name": "Romance",
          "url": "https://myanimelist.net/anime/genre/Romance"
        },
        {
          "mal_id": 0,
          "type": "anime",
          "name": "Slice of Life",
          "url": "https://myanimelist.net/anime/genre/Slice of Life"
        }
      ],
      "demographics": [
        {
          "mal_id": 0,
          "type": "anime",
          "name": "Shounen",
          "url": "https://myanimelist.net/anime/genre/Shounen"
        }
      ]
}

Since the mal id isn't put into the MalUrl object, so it can't parse it out of the URL

Just added it as part of the URL, previous URLs weren't valid

@purarue purarue changed the title bugfix: add genre/demographic IDs to MalUrl object bugfix/userlist: add genre/demographic IDs to URL Oct 21, 2021
@irfan-dahir irfan-dahir merged commit 1a8e0ab into jikan-me:master Oct 21, 2021
@irfan-dahir
Copy link
Copy Markdown
Collaborator

irfan-dahir commented Oct 21, 2021 •
edited
Loading

Thank you!

Edit: Pushed the update to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@purarue @irfan-dahir