Skip to content

Allow Symfony 7.0 to be used#547

Merged
irfan-dahir merged 3 commits intojikan-me:5.0.0from
rjd22:patch-1
Mar 5, 2024
Merged

Allow Symfony 7.0 to be used#547
irfan-dahir merged 3 commits intojikan-me:5.0.0from
rjd22:patch-1

Conversation

@rjd22
Copy link
Copy Markdown
Contributor

@rjd22 rjd22 commented Feb 24, 2024

Symfony 7.0 cannot be used because of held back packages. Since 7.0 doesn't seem to have significant changes to the version 7.0 packages we should be able to safely support both ^6.4 and ^7.0

Symfony 7.0 cannot be used because of held back packages. Since 7.0 doesn't seem to have significant changes to the version 7.0 packages we should be able to safely support both ^6.4 and ^7.0
@rjd22
Copy link
Copy Markdown
Contributor Author

rjd22 commented Mar 4, 2024

@irfan-dahir I also fixed the tests now. Could you take a look at this please?

@irfan-dahir
Copy link
Copy Markdown
Collaborator

Thanks for the PR @rjd22 , sorry I was out of the city for a couple of weeks so I wasn't able to look into this.
LGTM!

@irfan-dahir irfan-dahir merged commit 50eaee6 into jikan-me:5.0.0 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants